Skip to content

Add support for passing header X-Trino-Client-Tags #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

laserninja
Copy link

@laserninja laserninja commented Jul 17, 2025

Add support for X-Trino-Client-Tags header

Description

This PR adds support for the X-Trino-Client-Tags header in the Grafana Trino datasource plugin. The X-Trino-Client-Tags header is part of the official Trino client protocol and allows sending a comma-separated list of tag strings to identify Trino resource groups, which is useful for resource management and query monitoring.

How to Use

  1. Navigate to the Trino datasource configuration page in Grafana
  2. In the "Trino" section, find the "Client tags" field
  3. Enter a comma-separated list of tags (e.g., grafana,dashboard,analytics)
  4. Save the configuration

The tags will be automatically sent with every query to help Trino administrators identify and manage resource usage from different client sources.

Technical Details

  • The X-Trino-Client-Tags header is only sent when client tags are configured (optional field)
  • Tags are stored as a comma-separated string in the datasource configuration
  • No breaking changes - existing configurations will continue to work unchanged

Testing

  • Go backend builds successfully
  • Frontend TypeScript compiles without errors
  • All existing functionality remains intact
  • New feature is optional and doesn't affect existing setups

References

Copy link

cla-bot bot commented Jul 17, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@laserninja laserninja marked this pull request as ready for review July 26, 2025 03:46
@cla-bot cla-bot bot added the cla-signed label Jul 26, 2025
@laserninja laserninja marked this pull request as draft July 28, 2025 15:50
@laserninja laserninja marked this pull request as ready for review July 29, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant