Skip to content

fix(subscriber): make Layered propagate on_register_dispatch #3379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(subscriber): make Layered propagate on_register_dispatch #3379

wants to merge 1 commit into from

Conversation

bantonsson
Copy link

Motivation

The Layered implementation of Subscriber does not implement and propagate the on_register_dispatch callback. This means that combined layers will never have their on_register_dispatch methods called.

Solution

Implement the missing on_register_dispatch method.

@bantonsson bantonsson requested review from hawkw and a team as code owners September 19, 2025 12:00
@bantonsson
Copy link
Author

It seems like this was overlooked in #2269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw Awaiting requested review from hawkw hawkw is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bantonsson