Skip to content

Possible solution to Text Color issue #20 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

giripriyadarshan
Copy link

Kind of solved the text color issue I mentioned few hours ago. Please check it once as I'm new to Android development. The changes works on Nothing Phone 1 perfectly.

The Changes:

  • Added TextStyle to replace colors, fontWeights, fontSizes

@giripriyadarshan
Copy link
Author

Solves issue #20

And updates the phone numbers as and when it is input rather than the next cycle
This implementation allows for more cleaner experience on "few" certain use cases
@giripriyadarshan
Copy link
Author

Sorry, I added too many commits. But those low-level changes were kind of necessary for me. I hope it renders useful for others too.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@masterofdaemon
Copy link

Hello, i can't change text color in TogiCodeDialog (phoneCode), i can't pass my material Thame bacause i'm using material 3

@giripriyadarshan
Copy link
Author

Hello, i can't change text color in TogiCodeDialog (phoneCode), i can't pass my material Thame bacause i'm using material 3

Maybe this will help ..... https://github.com/giripriyadarshan/towwn-app/blob/main/app/src/main/java/com/giripriyadarshan/towwn/components/CCP.kt#L36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants