Inspector: make clickable URL's #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inst/store-inspector/modules.R
Outdated
| tryCatch( | ||
| { | ||
| text <- as.character(node) | ||
| text <- stringr::str_replace_all( |
There was a problem hiding this comment.
We only have stringr in suggests. Can we please use stringi or base R here?
| xml2::read_html(html_preview) | ||
|
|
||
| html_preview |> | ||
| xml2::xml_find_all(".//*[not(*)]") |> |
There was a problem hiding this comment.
Do we need to protect against text that is a link already, under an a tag?
There was a problem hiding this comment.
<a href="https://github.com">https://github.com<a/>
will become
<a href="https://github.com"><a href="https://github.com">https://github.com<a/><a/>
which is not an issue for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make urls clickable if they are not correctly rendered when casting markdown to HTML.
Some webpages do insert
<a>tags inside<code>blocks. While this is valid HTML, there's no direct supported Markdown conversion. This PR, converts any URL into a clickable link so the inspector can use it.