-
Notifications
You must be signed in to change notification settings - Fork 13
WIP ragnar_chat #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP ragnar_chat #55
Conversation
Thanks Daniel, this is a great start! Some questions that came to mind while I was reading through, in no particular order:
Out of curiosity, I generated a turns list with tool calls and results and used it to seed a chat history with a model that does not natively support tool calls (ollama serving gemma3n). The conversation works, but when asked to perform additional tool calls, the model stated it performed a search when it did not, then proceeded to hallucinate details.
|
IIUC you are suggesting that we do
Could cause the impression that
We don't prune all tool calls, only those added by ragnar, by using the tool definition name: Lines 156 to 159 in 993c042
The LLM will see just text. What kind of text representation of data.frames do you think it should see?
Yes, we can have a method for doing so. Eg managing tool calls at the top of the chat.
I think we can provide helpers for this. Not hard currently though, just write a function that takes a user chat and returns
Yes, we can do this. I think this is part of deoverlapping, so I think we could add this once we know the interface for ragnar_deoverlap. I think we can discuss this in follow up PR's though, once we agreee on the initial ihnterface. |
Implements an initial version of ragnar chat, adding support for eg:
This is pretty much work in progress for discussion. Relies on a few ellmer internals, etc