Skip to content

Log SIWA escalation failure error message #7740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jul 28, 2025


PR-Codex overview

This PR enhances error handling in the createSupportTicket function by checking the response of the fetch request to the SIWA feedback API. It logs an error message if the request fails, ensuring that ticket creation does not fail due to this issue.

Detailed summary

  • Changed the declaration of res to store the result of the fetch call.
  • Added a check for res.ok to determine if the fetch request was successful.
  • Included error logging for failed requests without interrupting the ticket creation process.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling for support ticket escalation, ensuring errors are logged if escalation fails without interrupting ticket creation.

@vercel vercel bot temporarily deployed to Preview – nebula July 28, 2025 19:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 28, 2025 19:14 Inactive
Copy link

vercel bot commented Jul 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 11:10pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jul 29, 2025 11:10pm
nebula ⬜️ Skipped (Inspect) Jul 29, 2025 11:10pm
thirdweb_playground ⬜️ Skipped (Inspect) Jul 29, 2025 11:10pm
wallet-ui ⬜️ Skipped (Inspect) Jul 29, 2025 11:10pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 July 28, 2025 19:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 28, 2025 19:14 Inactive
Copy link

changeset-bot bot commented Jul 28, 2025

⚠️ No Changeset found

Latest commit: e8470fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jul 28, 2025

Walkthrough

The change updates the createSupportTicket function in the support API. It now captures the response from an escalation fetch call, checks if the response is unsuccessful, and logs an error message with the response text if needed. This logging does not alter the main ticket creation flow or error handling.

Changes

Cohort / File(s) Change Summary
Support Ticket Escalation Logging
apps/dashboard/src/@/api/support.ts
Modified the escalation step to capture the fetch response, check for unsuccessful status, and log error messages with response text if escalation fails. Existing error handling is unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c06dc07 and e8470fc.

📒 Files selected for processing (1)
  • apps/dashboard/src/@/api/support.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/dashboard/src/@/api/support.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Size
  • GitHub Check: Unit Tests
  • GitHub Check: Build Packages
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 07-29-log_siwa_escalation_failure_error_message

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MananTank MananTank marked this pull request as ready for review July 28, 2025 19:14
@MananTank MananTank requested review from a team as code owners July 28, 2025 19:14
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jul 28, 2025
Copy link
Member Author

MananTank commented Jul 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.42%. Comparing base (a6483f4) to head (e8470fc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7740   +/-   ##
=======================================
  Coverage   56.42%   56.42%           
=======================================
  Files         904      904           
  Lines       58665    58665           
  Branches     4135     4135           
=======================================
  Hits        33100    33100           
  Misses      25460    25460           
  Partials      105      105           
Flag Coverage Δ
packages 56.42% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jul 28, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.16 KB (0%) 1.3 s (0%) 460 ms (+54.79% 🔺) 1.8 s
thirdweb (cjs) 352.91 KB (0%) 7.1 s (0%) 2.6 s (+20.14% 🔺) 9.6 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 146 ms (+921.12% 🔺) 260 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 18 ms (+227.64% 🔺) 28 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 143 ms (+144.47% 🔺) 528 ms

Copy link
Contributor

graphite-app bot commented Jul 29, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing error handling in the `createSupportTicket` function within the `support.ts` file. It ensures that even if the feedback submission fails, the ticket creation process continues without interruption.

### Detailed summary
- Changed the variable `res` to store the result of the `fetch` call to the SIWA URL.
- Added an error handling block to log an error message if the `fetch` response is not OK, without failing the ticket creation process.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Bug Fixes**
  * Improved error handling for support ticket escalation, ensuring errors are logged if escalation fails without interrupting ticket creation.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 07-29-log_siwa_escalation_failure_error_message branch from c06dc07 to e8470fc Compare July 29, 2025 23:02
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 29, 2025 23:02 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 29, 2025 23:02 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 29, 2025 23:02 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 29, 2025 23:02 Inactive
@graphite-app graphite-app bot merged commit e8470fc into main Jul 29, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 07-29-log_siwa_escalation_failure_error_message branch July 29, 2025 23:11
@vercel vercel bot temporarily deployed to Production – docs-v2 July 29, 2025 23:11 Inactive
@vercel vercel bot temporarily deployed to Production – nebula July 29, 2025 23:11 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground July 29, 2025 23:11 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants