Skip to content

Update portal label to TypeScript SDK #7658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

saminacodes
Copy link
Member

@saminacodes saminacodes commented Jul 21, 2025

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

[Portal] Fix: Update SDK title for TypeScript reference pages

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Updates the SDK title displayed on TypeScript reference pages from "Connect SDK" to "TypeScript SDK" for improved clarity and accuracy.

## How to test

Navigate to any `/references/typescript/v*/` page (e.g., `/references/typescript/v5/`). Verify the header displays "TypeScript SDK".

-->

Open Background Agent:
Web · Cursor

Slack Thread

Learn more about Background Agents


PR-Codex overview

This PR focuses on renaming references from Connect SDK to TypeScript SDK and thirdweb SDK across various files to improve clarity and consistency in documentation and code.

Detailed summary

  • Changed label from Connect SDKs to thirdweb SDKs in index.tsx.
  • Updated name from Connect SDK to TypeScript SDK in sidebar.tsx.
  • Modified sdkTitle from Connect SDK to TypeScript SDK in layout.tsx.
  • Replaced Connect SDK example with TypeScript SDK example in TransactionSimulator.tsx.
  • Changed Connect SDK to thirdweb SDK in code-overview.tsx.
  • Updated installation instructions from Connect SDK to TypeScript SDK in multiple markdown files.
  • Adjusted descriptions referencing Connect SDK to thirdweb SDK or TypeScript SDK in various markdown files.
  • Changed titles and descriptions in guides about connecting wallets and account factories to reflect TypeScript SDK.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Updated SDK naming from "Connect SDK" to "TypeScript SDK" and "thirdweb SDK" across documentation, guides, UI labels, and sidebar links for improved clarity and consistency.
  • Chores

    • Removed the "Engine" API link from the main navigation header.

Copy link
Contributor

coderabbitai bot commented Jul 21, 2025

Walkthrough

This update removes the "Engine" API link from the header navigation and changes multiple references of the SDK name from "Connect SDK" to either "TypeScript SDK" or "thirdweb SDK" across various documentation, UI components, metadata, and sidebar files. No logic or control flow is modified.

Changes

File(s) Change Summary
apps/portal/src/app/Header.tsx Removed "Engine" API link from the apisLinks array.
apps/portal/src/app/references/typescript/[version]/layout.tsx Changed sdkTitle from "Connect SDK" to "TypeScript SDK".
apps/dashboard/src/@/components/contracts/code-overview.tsx Changed external link label from "Connect SDK" to "thirdweb SDK".
apps/dashboard/src/app/(app)/(dashboard)/tools/transaction-simulator/components/TransactionSimulator.tsx Changed hyperlink label from "Connect SDK example" to "TypeScript SDK example".
apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/support/_components/contact-forms/connect/index.tsx Changed problem area label from "Connect SDKs" to "thirdweb SDKs".
apps/dashboard/src/app/(app)/team/components/Analytics/EmptyState.tsx Replaced "Connect SDK" with "TypeScript SDK" in heading and descriptive text.
apps/portal/src/app/contracts/explore/pre-built-contracts/account-factory/page.mdx Replaced "Connect SDK" with "thirdweb SDK" in usage instructions.
apps/portal/src/app/contracts/explore/pre-built-contracts/managed-account-factory/page.mdx Replaced "Connect SDK" with "thirdweb SDK" in usage description.
apps/portal/src/app/engine/v2/features/relayers/page.mdx Replaced "Connect SDK" with "TypeScript SDK" in transaction signing instructions.
apps/portal/src/app/infrastructure/sidebar.tsx Renamed sidebar link from "Connect SDK" to "TypeScript SDK" under Storage category.
apps/portal/src/app/pay/guides/cross-chain-swapping/page.mdx Updated step title and instructions from "Connect SDK" to "TypeScript SDK".
apps/portal/src/app/react/v5/connecting-wallets/ui-components/page.mdx Changed "Connect SDK" reference to "TypeScript SDK" in supported wallets description.
apps/portal/src/app/react/v5/in-app-wallet/how-to/interact-blockchain/page.mdx Replaced "Connect SDK" with "TypeScript SDK" in documentation text and card title.
apps/portal/src/app/react/v5/rainbow-kit-migrate/page.mdx Changed installation instruction from "connect SDK" to "TypeScript SDK".
apps/portal/src/app/typescript/v5/connecting-wallets/page.mdx Updated metadata and descriptions from "Connect SDK" to "TypeScript SDK".
apps/portal/src/app/typescript/v5/wallets/page.mdx Changed "Connect SDK" to "thirdweb SDKs" in supported wallets description.
apps/portal/src/app/wallets/external-wallets/com.coinbase.wallet/page.tsx Updated metadata description from "thirdweb Connect SDK" to "thirdweb TypeScript SDK".
apps/portal/src/app/wallets/quickstart/page.mdx Replaced "Connect SDK" with "TypeScript SDK" in introductory text and step titles.
packages/react-native-adapter/README.md Corrected package description from "thirdweb connect SDK" to "thirdweb SDK"; adjusted indentation.

Estimated code review effort

1 (~5 minutes)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a5ac7de and ecf6dbf.

📒 Files selected for processing (19)
  • apps/dashboard/src/@/components/contracts/code-overview.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/tools/transaction-simulator/components/TransactionSimulator.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/support/_components/contact-forms/connect/index.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/components/Analytics/EmptyState.tsx (1 hunks)
  • apps/portal/src/app/Header.tsx (0 hunks)
  • apps/portal/src/app/contracts/explore/pre-built-contracts/account-factory/page.mdx (1 hunks)
  • apps/portal/src/app/contracts/explore/pre-built-contracts/managed-account-factory/page.mdx (1 hunks)
  • apps/portal/src/app/engine/v2/features/relayers/page.mdx (1 hunks)
  • apps/portal/src/app/infrastructure/sidebar.tsx (1 hunks)
  • apps/portal/src/app/pay/guides/cross-chain-swapping/page.mdx (1 hunks)
  • apps/portal/src/app/react/v5/connecting-wallets/ui-components/page.mdx (1 hunks)
  • apps/portal/src/app/react/v5/in-app-wallet/how-to/interact-blockchain/page.mdx (1 hunks)
  • apps/portal/src/app/react/v5/rainbow-kit-migrate/page.mdx (1 hunks)
  • apps/portal/src/app/references/typescript/[version]/layout.tsx (1 hunks)
  • apps/portal/src/app/typescript/v5/connecting-wallets/page.mdx (2 hunks)
  • apps/portal/src/app/typescript/v5/wallets/page.mdx (1 hunks)
  • apps/portal/src/app/wallets/external-wallets/com.coinbase.wallet/page.tsx (1 hunks)
  • apps/portal/src/app/wallets/quickstart/page.mdx (1 hunks)
  • packages/react-native-adapter/README.md (3 hunks)
💤 Files with no reviewable changes (1)
  • apps/portal/src/app/Header.tsx
✅ Files skipped from review due to trivial changes (11)
  • apps/portal/src/app/react/v5/rainbow-kit-migrate/page.mdx
  • apps/dashboard/src/app/(app)/(dashboard)/tools/transaction-simulator/components/TransactionSimulator.tsx
  • apps/dashboard/src/@/components/contracts/code-overview.tsx
  • apps/portal/src/app/engine/v2/features/relayers/page.mdx
  • apps/portal/src/app/typescript/v5/wallets/page.mdx
  • apps/portal/src/app/react/v5/in-app-wallet/how-to/interact-blockchain/page.mdx
  • packages/react-native-adapter/README.md
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/support/_components/contact-forms/connect/index.tsx
  • apps/portal/src/app/wallets/quickstart/page.mdx
  • apps/portal/src/app/pay/guides/cross-chain-swapping/page.mdx
  • apps/portal/src/app/react/v5/connecting-wallets/ui-components/page.mdx
🚧 Files skipped from review as they are similar to previous changes (7)
  • apps/portal/src/app/contracts/explore/pre-built-contracts/account-factory/page.mdx
  • apps/portal/src/app/infrastructure/sidebar.tsx
  • apps/portal/src/app/contracts/explore/pre-built-contracts/managed-account-factory/page.mdx
  • apps/dashboard/src/app/(app)/team/components/Analytics/EmptyState.tsx
  • apps/portal/src/app/wallets/external-wallets/com.coinbase.wallet/page.tsx
  • apps/portal/src/app/references/typescript/[version]/layout.tsx
  • apps/portal/src/app/typescript/v5/connecting-wallets/page.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Lint Packages
  • GitHub Check: Size
  • GitHub Check: Build Packages
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Unit Tests
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 5:00pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 5:00pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
nebula ⬜️ Skipped (Inspect) Jul 21, 2025 5:00pm
thirdweb_playground ⬜️ Skipped (Inspect) Jul 21, 2025 5:00pm
wallet-ui ⬜️ Skipped (Inspect) Jul 21, 2025 5:00pm

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jul 21, 2025
Copy link
Contributor

graphite-app bot commented Jul 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

changeset-bot bot commented Jul 21, 2025

⚠️ No Changeset found

Latest commit: ecf6dbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 21, 2025 15:19 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 21, 2025 15:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www July 21, 2025 15:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 21, 2025 15:20 Inactive
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.40%. Comparing base (01daace) to head (ecf6dbf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7658   +/-   ##
=======================================
  Coverage   56.40%   56.40%           
=======================================
  Files         908      908           
  Lines       58228    58228           
  Branches     4226     4226           
=======================================
  Hits        32844    32844           
  Misses      25274    25274           
  Partials      110      110           
Flag Coverage Δ
packages 56.40% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@saminacodes saminacodes marked this pull request as ready for review July 21, 2025 15:23
@saminacodes saminacodes requested review from a team as code owners July 21, 2025 15:23
Copy link
Contributor

github-actions bot commented Jul 21, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.23 KB (0%) 1.3 s (0%) 304 ms (+96.06% 🔺) 1.6 s
thirdweb (cjs) 353.45 KB (0%) 7.1 s (0%) 1.4 s (+9.97% 🔺) 8.4 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 110 ms (+1118.47% 🔺) 224 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 72 ms (+2166.11% 🔺) 82 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 122 ms (+458.58% 🔺) 514 ms

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/portal/src/app/references/typescript/[version]/layout.tsx (1)

17-17: Trim trailing space in the <title> string
A super-fluous space at the end of the string may leak into the rendered <title> tag or fail strict string comparisons in tests.

-  title: "References | thirdweb TypeScript SDK ",
+  title: "References | thirdweb TypeScript SDK",
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a534580 and 115d7c1.

📒 Files selected for processing (2)
  • apps/portal/src/app/Header.tsx (0 hunks)
  • apps/portal/src/app/references/typescript/[version]/layout.tsx (1 hunks)
💤 Files with no reviewable changes (1)
  • apps/portal/src/app/Header.tsx
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose

Files:

  • apps/portal/src/app/references/typescript/[version]/layout.tsx
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit Inference Engine (CLAUDE.md)

Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)

Files:

  • apps/portal/src/app/references/typescript/[version]/layout.tsx
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Server Components (Node edge): Start files with `import "server-only";`
apps/portal/src/app/references/typescript/[version]/layout.tsx (10)

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to src/exports/react.native.ts : React Native specific exports are in src/exports/react.native.ts

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{tsx} : Expose className prop on root element of components for overrides

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Server Components (Node edge): Start files with import "server-only";

Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/layout.tsx : Building layout shells (layout.tsx) and top-level pages that mainly assemble data.

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Use design system tokens (e.g., bg-card, border-border, text-muted-foreground)

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Client Components (browser): Begin files with 'use client';

Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{ts,tsx} : Export default async functions without 'use client'; – they run on the Node edge.

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Import UI primitives from @/components/ui/* (Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to **/*.{ts,tsx} : Write idiomatic TypeScript with explicit function declarations and return types

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to **/*.{ts,tsx} : Comment only ambiguous logic; avoid restating TypeScript in prose

🔇 Additional comments (1)
apps/portal/src/app/references/typescript/[version]/layout.tsx (1)

8-8: ✅ SDK title change aligns with new branding
The update from “Connect SDK” → “TypeScript SDK” is correct and consistent with the rest of the metadata below.

@vercel vercel bot temporarily deployed to Preview – wallet-ui July 21, 2025 15:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 21, 2025 15:51 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 21, 2025 15:51 Inactive
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages labels Jul 21, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
apps/portal/src/app/typescript/v5/connecting-wallets/page.mdx (1)

15-16: Optional wording tweak for clarity

Insert the article “the” before the SDK name for smoother reading.

-		"Learn how to connect various types of wallets using TypeScript SDK",
+		"Learn how to connect various types of wallets using the TypeScript SDK",
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 115d7c1 and 52de7dd.

📒 Files selected for processing (17)
  • apps/dashboard/src/@/components/contracts/code-overview.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/tools/transaction-simulator/components/TransactionSimulator.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/support/_components/contact-forms/connect/index.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/components/Analytics/EmptyState.tsx (1 hunks)
  • apps/portal/src/app/contracts/explore/pre-built-contracts/account-factory/page.mdx (1 hunks)
  • apps/portal/src/app/contracts/explore/pre-built-contracts/managed-account-factory/page.mdx (1 hunks)
  • apps/portal/src/app/engine/v2/features/relayers/page.mdx (1 hunks)
  • apps/portal/src/app/infrastructure/sidebar.tsx (1 hunks)
  • apps/portal/src/app/pay/guides/cross-chain-swapping/page.mdx (1 hunks)
  • apps/portal/src/app/react/v5/connecting-wallets/ui-components/page.mdx (1 hunks)
  • apps/portal/src/app/react/v5/in-app-wallet/how-to/interact-blockchain/page.mdx (1 hunks)
  • apps/portal/src/app/react/v5/rainbow-kit-migrate/page.mdx (1 hunks)
  • apps/portal/src/app/typescript/v5/connecting-wallets/page.mdx (2 hunks)
  • apps/portal/src/app/typescript/v5/wallets/page.mdx (1 hunks)
  • apps/portal/src/app/wallets/external-wallets/com.coinbase.wallet/page.tsx (1 hunks)
  • apps/portal/src/app/wallets/quickstart/page.mdx (1 hunks)
  • packages/react-native-adapter/README.md (3 hunks)
✅ Files skipped from review due to trivial changes (16)
  • apps/dashboard/src/@/components/contracts/code-overview.tsx
  • apps/portal/src/app/react/v5/rainbow-kit-migrate/page.mdx
  • apps/portal/src/app/engine/v2/features/relayers/page.mdx
  • apps/portal/src/app/infrastructure/sidebar.tsx
  • apps/dashboard/src/app/(app)/team/components/Analytics/EmptyState.tsx
  • apps/portal/src/app/wallets/quickstart/page.mdx
  • apps/portal/src/app/pay/guides/cross-chain-swapping/page.mdx
  • apps/portal/src/app/react/v5/connecting-wallets/ui-components/page.mdx
  • apps/portal/src/app/contracts/explore/pre-built-contracts/account-factory/page.mdx
  • apps/portal/src/app/typescript/v5/wallets/page.mdx
  • apps/portal/src/app/contracts/explore/pre-built-contracts/managed-account-factory/page.mdx
  • apps/dashboard/src/app/(app)/(dashboard)/tools/transaction-simulator/components/TransactionSimulator.tsx
  • apps/portal/src/app/wallets/external-wallets/com.coinbase.wallet/page.tsx
  • apps/portal/src/app/react/v5/in-app-wallet/how-to/interact-blockchain/page.mdx
  • packages/react-native-adapter/README.md
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/support/_components/contact-forms/connect/index.tsx
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : Anything that consumes hooks from `@tanstack/react-query` or thirdweb SDKs.
Learnt from: MananTank
PR: thirdweb-dev/js#7227
File: apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/OpenEditionMetadata.tsx:26-26
Timestamp: 2025-05-30T17:14:25.332Z
Learning: The ModuleCardUIProps interface already includes a client prop of type ThirdwebClient, so when components use `Omit<ModuleCardUIProps, "children" | "updateButton">`, they inherit the client prop without needing to add it explicitly.
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Server Components (Node edge): Start files with `import "server-only";`
apps/portal/src/app/typescript/v5/connecting-wallets/page.mdx (11)

Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : Interactive UI that relies on hooks (useState, useEffect, React Query, wallet hooks).

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to test/src/test-wallets.ts : Predefined test accounts are in test/src/test-wallets.ts

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Use design system tokens (e.g., bg-card, border-border, text-muted-foreground)

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to src/exports/react.native.ts : React Native specific exports are in src/exports/react.native.ts

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Client Components (browser): Begin files with 'use client';

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified Wallet and Account interfaces in wallet architecture

Learnt from: gregfromstl
PR: #7450
File: packages/thirdweb/src/bridge/Webhook.ts:57-81
Timestamp: 2025-06-26T19:46:04.024Z
Learning: In the onramp webhook schema (packages/thirdweb/src/bridge/Webhook.ts), the currencyAmount field is intentionally typed as z.number() while other amount fields use z.string() because currencyAmount represents fiat currency amounts in decimals (like $10.50), whereas other amount fields represent token amounts in wei (very large integers that benefit from bigint representation). The different naming convention (currencyAmount vs amount) reflects this intentional distinction.

Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : Anything that consumes hooks from @tanstack/react-query or thirdweb SDKs.

🪛 LanguageTool
apps/portal/src/app/typescript/v5/connecting-wallets/page.mdx

[grammar] ~13-~13: Ensure spelling is correct
Context: ...ipt", }, title: "Connecting Wallets | TypeScriot SDK", description: "Learn how to con...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Unit Tests
  • GitHub Check: Lint Packages
  • GitHub Check: Build Packages
  • GitHub Check: Size
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/portal/src/app/typescript/v5/connecting-wallets/page.mdx (1)

28-28: Consistency check

Line already uses “the TypeScript SDK”; once the previous nit-pick is applied, wording across the file will be consistent. No further action needed.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 21, 2025 15:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 21, 2025 15:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www July 21, 2025 15:58 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 21, 2025 15:58 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 21, 2025 16:19 Inactive
@saminacodes saminacodes requested a review from MananTank July 21, 2025 16:19
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 21, 2025 16:19 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 21, 2025 16:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 21, 2025 16:19 Inactive
@MananTank MananTank added the merge-queue Adds the pull request to Graphite's merge queue. label Jul 21, 2025
Copy link
Member

MananTank commented Jul 21, 2025

Merge activity

```
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

[Portal] Fix: Update SDK title for TypeScript reference pages

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Updates the SDK title displayed on TypeScript reference pages from "Connect SDK" to "TypeScript SDK" for improved clarity and accuracy.

## How to test

Navigate to any `/references/typescript/v*/` page (e.g., `/references/typescript/v5/`). Verify the header displays "TypeScript SDK".

-->
```

---

**Open Background Agent:**
[Web](https://www.cursor.com/agents?id=bc-2dec36af-4b62-431c-b277-891c1b46bb48) · [Cursor](https://cursor.com/background-agent?bcId=bc-2dec36af-4b62-431c-b277-891c1b46bb48)

[Slack Thread](https://thirdwebdev.slack.com/archives/C04DYC3G5NZ/p1753110978408999?thread_ts=1753110978.408999&cid=C04DYC3G5NZ)

Learn more about [Background Agents](https://docs.cursor.com/background-agents)

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on renaming references from `Connect SDK` to `TypeScript SDK` and `thirdweb SDK` across multiple files in the project, enhancing clarity and consistency in the documentation and codebase.

### Detailed summary
- Updated `label` from `Connect SDKs` to `thirdweb SDKs`.
- Changed `name` from `Connect SDK` to `TypeScript SDK`.
- Modified `sdkTitle` from `Connect SDK` to `TypeScript SDK`.
- Adjusted example descriptions and titles to reflect `TypeScript SDK`.
- Updated installation instructions to refer to `TypeScript SDK`.
- Revised descriptions related to wallet support to mention `thirdweb SDKs`.
- Changed references in guides and documentation from `Connect SDK` to `TypeScript SDK`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

* **New Features**
  * Updated SDK naming from "Connect SDK" to "TypeScript SDK" and "thirdweb SDK" across documentation, guides, UI labels, and sidebar links for improved clarity and consistency.

* **Chores**
  * Removed the "Engine" API link from the main navigation header.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the cursor/update-portal-label-to-typescript-sdk-050c branch from d7fcd04 to ecf6dbf Compare July 21, 2025 16:52
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 21, 2025 16:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 21, 2025 16:52 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 21, 2025 16:52 Inactive
@graphite-app graphite-app bot merged commit ecf6dbf into main Jul 21, 2025
25 checks passed
@graphite-app graphite-app bot deleted the cursor/update-portal-label-to-typescript-sdk-050c branch July 21, 2025 17:01
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Jul 21, 2025
@vercel vercel bot temporarily deployed to Production – nebula July 21, 2025 17:01 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui July 21, 2025 17:01 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground July 21, 2025 17:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants