Skip to content

[TOOL-5075] SDK: Fix various alignment issues in components #7657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jul 21, 2025


PR-Codex overview

This PR focuses on fixing various alignment issues in React components across the thirdweb package, specifically enhancing hover effects and ensuring consistent styles.

Detailed summary

  • Updated hover styles in multiple components to improve visual feedback.
  • Set all: "unset" for consistent styling reset.
  • Adjusted colors for hover states to align with theme colors.
  • Ensured proper alignment and box-sizing in UI components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes

    • Resolved various alignment issues in React components to improve visual consistency across the interface.
  • Chores

    • Updated internal documentation to reflect the latest patch addressing alignment fixes.

Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 6:08pm
nebula ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 6:08pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 6:08pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 6:08pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 6:08pm

Copy link

linear bot commented Jul 21, 2025

Copy link

changeset-bot bot commented Jul 21, 2025

🦋 Changeset detected

Latest commit: 22bf68a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jul 21, 2025

Walkthrough

The changes systematically reorder the CSS property all: "unset" to the beginning of style objects in multiple React styled components across the codebase. This affects button, link, and container components, ensuring CSS resets are applied before other styles. No logic, control flow, or exported entity signatures were modified.

Changes

Files/Groups Change Summary
.changeset/sad-vans-wait.md Added a changeset documenting a patch update for "thirdweb" regarding alignment fixes in React components.
packages/thirdweb/src/react/web/ui/ConnectWallet/Details.tsx
.../MenuButton.tsx
.../WalletEntryButton.tsx
.../screens/ReceiveFunds.tsx
.../NetworkSelector.tsx
Reordered all: "unset" to the top of style objects in various ConnectWallet-related button and container components.
packages/thirdweb/src/react/web/ui/TransactionButton/DepositScreen.tsx Moved all: "unset" to the top of the style object in WalletAddressContainer.
packages/thirdweb/src/react/web/ui/components/buttons.tsx Moved all: "unset" to the start of style objects in Button and IconButton components.
packages/thirdweb/src/react/web/ui/components/text.tsx Moved all: "unset" to the start of the style object in the Link component.
packages/thirdweb/src/react/web/wallets/shared/GetStartedScreen.tsx
.../OTPLoginUI.tsx
Moved all: "unset" to the start of style objects in ButtonLink and LinkButton components.

Estimated code review effort

1 (~8 minutes)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80b3b74 and 22bf68a.

📒 Files selected for processing (11)
  • .changeset/sad-vans-wait.md (1 hunks)
  • packages/thirdweb/src/react/web/ui/ConnectWallet/Details.tsx (1 hunks)
  • packages/thirdweb/src/react/web/ui/ConnectWallet/MenuButton.tsx (2 hunks)
  • packages/thirdweb/src/react/web/ui/ConnectWallet/NetworkSelector.tsx (2 hunks)
  • packages/thirdweb/src/react/web/ui/ConnectWallet/WalletEntryButton.tsx (1 hunks)
  • packages/thirdweb/src/react/web/ui/ConnectWallet/screens/ReceiveFunds.tsx (1 hunks)
  • packages/thirdweb/src/react/web/ui/TransactionButton/DepositScreen.tsx (1 hunks)
  • packages/thirdweb/src/react/web/ui/components/buttons.tsx (2 hunks)
  • packages/thirdweb/src/react/web/ui/components/text.tsx (1 hunks)
  • packages/thirdweb/src/react/web/wallets/shared/GetStartedScreen.tsx (1 hunks)
  • packages/thirdweb/src/react/web/wallets/shared/OTPLoginUI.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/thirdweb/src/react/web/ui/ConnectWallet/Details.tsx
🚧 Files skipped from review as they are similar to previous changes (10)
  • packages/thirdweb/src/react/web/ui/ConnectWallet/WalletEntryButton.tsx
  • packages/thirdweb/src/react/web/ui/ConnectWallet/screens/ReceiveFunds.tsx
  • packages/thirdweb/src/react/web/wallets/shared/GetStartedScreen.tsx
  • packages/thirdweb/src/react/web/ui/TransactionButton/DepositScreen.tsx
  • packages/thirdweb/src/react/web/wallets/shared/OTPLoginUI.tsx
  • .changeset/sad-vans-wait.md
  • packages/thirdweb/src/react/web/ui/ConnectWallet/MenuButton.tsx
  • packages/thirdweb/src/react/web/ui/ConnectWallet/NetworkSelector.tsx
  • packages/thirdweb/src/react/web/ui/components/buttons.tsx
  • packages/thirdweb/src/react/web/ui/components/text.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Unit Tests
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MananTank MananTank marked this pull request as ready for review July 21, 2025 15:13
@MananTank MananTank requested review from a team as code owners July 21, 2025 15:13
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jul 21, 2025
Copy link
Member Author

MananTank commented Jul 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented Jul 21, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.23 KB (0%) 1.3 s (0%) 684 ms (+84.74% 🔺) 2 s
thirdweb (cjs) 353.45 KB (0%) 7.1 s (0%) 2.9 s (+3.78% 🔺) 10 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 239 ms (+538.79% 🔺) 353 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 37 ms (+372.54% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 131 ms (+64.26% 🔺) 523 ms

Copy link

codecov bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.40%. Comparing base (68dd4dc) to head (22bf68a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/react/web/ui/ConnectWallet/WalletEntryButton.tsx 0.00% 1 Missing ⚠️
...c/react/web/ui/TransactionButton/DepositScreen.tsx 0.00% 1 Missing ⚠️
.../src/react/web/wallets/shared/GetStartedScreen.tsx 0.00% 1 Missing ⚠️
...irdweb/src/react/web/wallets/shared/OTPLoginUI.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7657   +/-   ##
=======================================
  Coverage   56.40%   56.40%           
=======================================
  Files         908      908           
  Lines       58228    58228           
  Branches     4226     4226           
=======================================
  Hits        32844    32844           
  Misses      25274    25274           
  Partials      110      110           
Flag Coverage Δ
packages 56.40% <66.66%> (ø)
Files with missing lines Coverage Δ
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx 57.92% <100.00%> (ø)
...dweb/src/react/web/ui/ConnectWallet/MenuButton.tsx 100.00% <100.00%> (ø)
...src/react/web/ui/ConnectWallet/NetworkSelector.tsx 36.43% <100.00%> (ø)
...eact/web/ui/ConnectWallet/screens/ReceiveFunds.tsx 90.66% <100.00%> (ø)
...s/thirdweb/src/react/web/ui/components/buttons.tsx 81.81% <100.00%> (ø)
...ages/thirdweb/src/react/web/ui/components/text.tsx 100.00% <100.00%> (ø)
...c/react/web/ui/ConnectWallet/WalletEntryButton.tsx 14.28% <0.00%> (ø)
...c/react/web/ui/TransactionButton/DepositScreen.tsx 12.86% <0.00%> (ø)
.../src/react/web/wallets/shared/GetStartedScreen.tsx 11.37% <0.00%> (ø)
...irdweb/src/react/web/wallets/shared/OTPLoginUI.tsx 6.04% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

graphite-app bot commented Jul 21, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on fixing various alignment issues in React components within the `thirdweb` package, enhancing hover states and visual consistency across different UI elements.

### Detailed summary
- Updated hover styles in several components to improve visual feedback.
- Adjusted `all` property to "unset" for better styling control.
- Modified colors and borders in `OTPLoginUI.tsx`, `ReceiveFunds.tsx`, `DepositScreen.tsx`, and others for consistency.
- Enhanced button styles in `MenuButton.tsx`, `WalletEntryButton.tsx`, and `NetworkSelector.tsx`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Bug Fixes**
  * Resolved various alignment issues in React components to improve visual consistency across the interface.

* **Chores**
  * Updated internal documentation to reflect the latest patch addressing alignment fixes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants