Deprecate modular contracts from Explore #7515
Conversation
Co-authored-by: jake <jake@thirdweb.com>
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe updates deprecate the "Pre-built Modular" contracts from the Explore UI and documentation. The relevant category is hidden in the dashboard, deprecation warnings are added to related documentation pages, sidebar navigation links to modular contracts are removed, and redirects for deprecated modular contract URLs are added. No functional or control flow changes are introduced. Changes
Sequence Diagram(s)No sequence diagram is generated as the changes are limited to configuration, documentation, UI visibility, and redirects without affecting control flow or feature logic. Estimated code review effort2 (~20 minutes) Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
Dashboard
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7515 +/- ##
=======================================
Coverage 56.36% 56.36%
=======================================
Files 908 908
Lines 58244 58244
Branches 4226 4226
=======================================
Hits 32829 32829
Misses 25307 25307
Partials 108 108
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Co-authored-by: jake <jake@thirdweb.com>
graphite-app
bot
removed
the
merge-queue
|
This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| <Callout variant="warning" title="Deprecated"> | ||
| Pre-built modular contracts have been deprecated from the Explore section. While this documentation remains available for existing users, we recommend using [standard NFT collection contracts](/contracts/explore/pre-built-contracts/nft-collection) for new deployments. | ||
| </Callout> | ||
|
|
||
| The NFT Collection contract creates a unique collection of NFTs based on the ERC-721A standard. NFTs are minted to the creator’s wallet as they are added to the collection. NFTs are still transferable, able to be sold on a marketplace, and perform any other actions as defined by ERC-721A. | ||
|
|
||
| For advanced use-cases requiring , NFT Collection includes signature-based minting capabilities. |
There was a problem hiding this comment.
The sentence appears to be incomplete after "requiring". It either needs to complete the thought by specifying what advanced use-cases require, or the word "requiring" should be removed. For example:
| For advanced use-cases requiring , NFT Collection includes signature-based minting capabilities. | |
| For advanced use-cases, NFT Collection includes signature-based minting capabilities. |
Or alternatively, complete the sentence with the missing information:
| For advanced use-cases requiring , NFT Collection includes signature-based minting capabilities. | |
| For advanced use-cases requiring custom minting logic, NFT Collection includes signature-based minting capabilities. |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
PR-Codex overview
This PR focuses on deprecating the
modularcontracts in the Explore section, encouraging users to transition to standard contracts. It updates references and documentation to reflect this change while maintaining some accessibility for existing users.Detailed summary
modularcontracts indata.ts.CATEGORIESto keepMODULAR_CONTRACTSbut marked as deprecated.tokenandnft-collectionpages.pre-built-modularcontracts changed to point topre-built-contracts.pre-built-modularcontracts insidebar.tsx.Summary by CodeRabbit
Bug Fixes
Documentation