Remove return extension for wp_dropdown_pages (#247)

As documented, `wp_dropdown_pages()` always returns a string. See lines 1245-1249 in [wp-includes/post-template.php](https://github.com/WordPress/WordPress/blob/e25ffd14269ad6461aba63e3119ac5603502bf06/wp-includes/post-template.php#L1245-L1249).

Author: IanDelMar

src/EchoKeyDynamicFunctionReturnTypeExtension.php

@@ -30,7 +30,6 @@ class EchoKeyDynamicFunctionReturnTypeExtension implements \PHPStan\Type\Dynamic
         'get_search_form' => 0,
         'the_title_attribute' => 0,
         'wp_dropdown_languages' => 0,
-        'wp_dropdown_pages' => 0,
         'wp_dropdown_users' => 0,
         'wp_get_archives' => 0,
         'wp_link_pages' => 0,
@@ -89,7 +88,6 @@ public function isFunctionSupported(FunctionReflection $functionReflection): boo
      * @see https://developer.wordpress.org/reference/functions/get_search_form/
      * @see https://developer.wordpress.org/reference/functions/the_title_attribute/
      * @see https://developer.wordpress.org/reference/functions/wp_dropdown_languages/
-     * @see https://developer.wordpress.org/reference/functions/wp_dropdown_pages/
      * @see https://developer.wordpress.org/reference/functions/wp_dropdown_users/
      * @see https://developer.wordpress.org/reference/functions/wp_get_archives/
      * @see https://developer.wordpress.org/reference/functions/wp_link_pages/

tests/data/echo_key.php

@@ -10,7 +10,6 @@
 assertType('void', get_search_form());
 assertType('void', the_title_attribute());
 assertType('void', wp_dropdown_languages());
-assertType('void', wp_dropdown_pages());
 assertType('void', wp_dropdown_users());
 assertType('void', wp_get_archives());
 assertType('void', wp_link_pages());
@@ -28,7 +27,6 @@
 assertType('void', get_search_form($args));
 assertType('void', the_title_attribute($args));
 assertType('void', wp_dropdown_languages($args));
-assertType('void', wp_dropdown_pages($args));
 assertType('void', wp_dropdown_users($args));
 assertType('void', wp_get_archives($args));
 assertType('void', wp_link_pages($args));
@@ -44,7 +42,6 @@
 // Explicit array key value of 1
 $args = ['echo' => 1];
 assertType('void', wp_dropdown_languages($args));
-assertType('void', wp_dropdown_pages($args));
 assertType('void', wp_dropdown_users($args));
 assertType('void', wp_get_archives($args));
 assertType('void', wp_link_pages($args));
@@ -56,7 +53,6 @@
 assertType('string', get_search_form($args));
 assertType('string|void', the_title_attribute($args));
 assertType('string|void', wp_dropdown_languages($args));
-assertType('string', wp_dropdown_pages($args));
 assertType('string', wp_dropdown_users($args));
 assertType('string|void', wp_get_archives($args));
 assertType('string', wp_link_pages($args));
@@ -72,7 +68,6 @@
 // Explicit array key value of 0
 $args = ['echo' => 0];
 assertType('string|void', wp_dropdown_languages($args));
-assertType('string', wp_dropdown_pages($args));
 assertType('string', wp_dropdown_users($args));
 assertType('string|void', wp_get_archives($args));
 assertType('string', wp_link_pages($args));
@@ -84,7 +79,6 @@
 assertType('string|void', get_search_form($args));
 assertType('string|void', the_title_attribute($args));
 assertType('string|void', wp_dropdown_languages($args));
-assertType('string|void', wp_dropdown_pages($args));
 assertType('string|void', wp_dropdown_users($args));
 assertType('string|void', wp_get_archives($args));
 assertType('string|void', wp_link_pages($args));
@@ -101,7 +95,6 @@
 $args = 'akey=avalue';
 assertType('void', the_title_attribute($args));
 assertType('void', wp_dropdown_languages($args));
-assertType('void', wp_dropdown_pages($args));
 assertType('void', wp_dropdown_users($args));
 assertType('void', wp_get_archives($args));
 assertType('void', wp_link_pages($args));
@@ -117,7 +110,6 @@
 $args = 'echo=nonemptynonnumeric&akey=avalue';
 assertType('void', the_title_attribute($args));
 assertType('void', wp_dropdown_languages($args));
-assertType('void', wp_dropdown_pages($args));
 assertType('void', wp_dropdown_users($args));
 assertType('void', wp_get_archives($args));
 assertType('void', wp_link_pages($args));
@@ -133,7 +125,6 @@
 $args = 'echo=1&akey=avalue';
 assertType('void', the_title_attribute($args));
 assertType('void', wp_dropdown_languages($args));
-assertType('void', wp_dropdown_pages($args));
 assertType('void', wp_dropdown_users($args));
 assertType('void', wp_get_archives($args));
 assertType('void', wp_link_pages($args));
@@ -149,7 +140,6 @@
 $args = 'echo=0&akey=avalue';
 assertType('string|void', the_title_attribute($args));
 assertType('string|void', wp_dropdown_languages($args));
-assertType('string', wp_dropdown_pages($args));
 assertType('string', wp_dropdown_users($args));
 assertType('string|void', wp_get_archives($args));
 assertType('string', wp_link_pages($args));
@@ -165,7 +155,6 @@
 $args = 'echo=&akey=avalue';
 assertType('string|void', the_title_attribute($args));
 assertType('string|void', wp_dropdown_languages($args));
-assertType('string', wp_dropdown_pages($args));
 assertType('string', wp_dropdown_users($args));
 assertType('string|void', wp_get_archives($args));
 assertType('string', wp_link_pages($args));
@@ -182,7 +171,6 @@
 assertType('string|void', get_search_form($args));
 assertType('string|void', the_title_attribute($args));
 assertType('string|void', wp_dropdown_languages($args));
-assertType('string|void', wp_dropdown_pages($args));
 assertType('string|void', wp_dropdown_users($args));
 assertType('string|void', wp_get_archives($args));
 assertType('string|void', wp_link_pages($args));
@@ -201,7 +189,6 @@
 assertType('string|void', get_search_form($args));
 assertType('string|void', the_title_attribute($args));
 assertType('string|void', wp_dropdown_languages($args));
-assertType('string|void', wp_dropdown_pages($args));
 assertType('string|void', wp_dropdown_users($args));
 assertType('string|void', wp_get_archives($args));
 assertType('string|void', wp_link_pages($args));