Skip to content

Commit 54594b9

Browse files
IanDelMarIanDelMar
authored
Remove return extension for wp_dropdown_categories (#246)
wp_dropdown_categories always returns a string as documented
1 parent bb578e2 commit 54594b9

File tree

2 files changed

+0
-15
lines changed

2 files changed

+0
-15
lines changed

‎src/EchoKeyDynamicFunctionReturnTypeExtension.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ class EchoKeyDynamicFunctionReturnTypeExtension implements \PHPStan\Type\Dynamic
2929
private const FUNCTIONS = [
3030
'get_search_form' => 0,
3131
'the_title_attribute' => 0,
32-
'wp_dropdown_categories' => 0,
3332
'wp_dropdown_languages' => 0,
3433
'wp_dropdown_pages' => 0,
3534
'wp_dropdown_users' => 0,
@@ -89,7 +88,6 @@ public function isFunctionSupported(FunctionReflection $functionReflection): boo
8988
/**
9089
* @see https://developer.wordpress.org/reference/functions/get_search_form/
9190
* @see https://developer.wordpress.org/reference/functions/the_title_attribute/
92-
* @see https://developer.wordpress.org/reference/functions/wp_dropdown_categories/
9391
* @see https://developer.wordpress.org/reference/functions/wp_dropdown_languages/
9492
* @see https://developer.wordpress.org/reference/functions/wp_dropdown_pages/
9593
* @see https://developer.wordpress.org/reference/functions/wp_dropdown_users/

‎tests/data/echo_key.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
// Default value of true
1010
assertType('void', get_search_form());
1111
assertType('void', the_title_attribute());
12-
assertType('void', wp_dropdown_categories());
1312
assertType('void', wp_dropdown_languages());
1413
assertType('void', wp_dropdown_pages());
1514
assertType('void', wp_dropdown_users());
@@ -28,7 +27,6 @@
2827
$args = ['echo' => true];
2928
assertType('void', get_search_form($args));
3029
assertType('void', the_title_attribute($args));
31-
assertType('void', wp_dropdown_categories($args));
3230
assertType('void', wp_dropdown_languages($args));
3331
assertType('void', wp_dropdown_pages($args));
3432
assertType('void', wp_dropdown_users($args));
@@ -45,7 +43,6 @@
4543

4644
// Explicit array key value of 1
4745
$args = ['echo' => 1];
48-
assertType('void', wp_dropdown_categories($args));
4946
assertType('void', wp_dropdown_languages($args));
5047
assertType('void', wp_dropdown_pages($args));
5148
assertType('void', wp_dropdown_users($args));
@@ -58,7 +55,6 @@
5855
$args = ['echo' => false];
5956
assertType('string', get_search_form($args));
6057
assertType('string|void', the_title_attribute($args));
61-
assertType('string', wp_dropdown_categories($args));
6258
assertType('string|void', wp_dropdown_languages($args));
6359
assertType('string', wp_dropdown_pages($args));
6460
assertType('string', wp_dropdown_users($args));
@@ -75,7 +71,6 @@
7571

7672
// Explicit array key value of 0
7773
$args = ['echo' => 0];
78-
assertType('string', wp_dropdown_categories($args));
7974
assertType('string|void', wp_dropdown_languages($args));
8075
assertType('string', wp_dropdown_pages($args));
8176
assertType('string', wp_dropdown_users($args));
@@ -88,7 +83,6 @@
8883
$args = ['echo' => $_GET['foo']];
8984
assertType('string|void', get_search_form($args));
9085
assertType('string|void', the_title_attribute($args));
91-
assertType('string|void', wp_dropdown_categories($args));
9286
assertType('string|void', wp_dropdown_languages($args));
9387
assertType('string|void', wp_dropdown_pages($args));
9488
assertType('string|void', wp_dropdown_users($args));
@@ -106,7 +100,6 @@
106100
// Explicit no query string value
107101
$args = 'akey=avalue';
108102
assertType('void', the_title_attribute($args));
109-
assertType('void', wp_dropdown_categories($args));
110103
assertType('void', wp_dropdown_languages($args));
111104
assertType('void', wp_dropdown_pages($args));
112105
assertType('void', wp_dropdown_users($args));
@@ -123,7 +116,6 @@
123116
// Explicit non empty non numeric query string value (includes 'true' & 'false')
124117
$args = 'echo=nonemptynonnumeric&akey=avalue';
125118
assertType('void', the_title_attribute($args));
126-
assertType('void', wp_dropdown_categories($args));
127119
assertType('void', wp_dropdown_languages($args));
128120
assertType('void', wp_dropdown_pages($args));
129121
assertType('void', wp_dropdown_users($args));
@@ -140,7 +132,6 @@
140132
// Explicit non zero numeric query string value
141133
$args = 'echo=1&akey=avalue';
142134
assertType('void', the_title_attribute($args));
143-
assertType('void', wp_dropdown_categories($args));
144135
assertType('void', wp_dropdown_languages($args));
145136
assertType('void', wp_dropdown_pages($args));
146137
assertType('void', wp_dropdown_users($args));
@@ -157,7 +148,6 @@
157148
// Explicit query string value of 0
158149
$args = 'echo=0&akey=avalue';
159150
assertType('string|void', the_title_attribute($args));
160-
assertType('string', wp_dropdown_categories($args));
161151
assertType('string|void', wp_dropdown_languages($args));
162152
assertType('string', wp_dropdown_pages($args));
163153
assertType('string', wp_dropdown_users($args));
@@ -174,7 +164,6 @@
174164
// Explicit empty query string value
175165
$args = 'echo=&akey=avalue';
176166
assertType('string|void', the_title_attribute($args));
177-
assertType('string', wp_dropdown_categories($args));
178167
assertType('string|void', wp_dropdown_languages($args));
179168
assertType('string', wp_dropdown_pages($args));
180169
assertType('string', wp_dropdown_users($args));
@@ -192,7 +181,6 @@
192181
$args = $_GET['foo'];
193182
assertType('string|void', get_search_form($args));
194183
assertType('string|void', the_title_attribute($args));
195-
assertType('string|void', wp_dropdown_categories($args));
196184
assertType('string|void', wp_dropdown_languages($args));
197185
assertType('string|void', wp_dropdown_pages($args));
198186
assertType('string|void', wp_dropdown_users($args));
@@ -212,7 +200,6 @@
212200
$args = '';
213201
assertType('string|void', get_search_form($args));
214202
assertType('string|void', the_title_attribute($args));
215-
assertType('string|void', wp_dropdown_categories($args));
216203
assertType('string|void', wp_dropdown_languages($args));
217204
assertType('string|void', wp_dropdown_pages($args));
218205
assertType('string|void', wp_dropdown_users($args));

0 commit comments

Comments
 (0)