Add tests (#58)

Co-authored-by: Viktor Szépe <viktor@szepe.net>

Author: johnbillion

.editorconfig

@@ -10,7 +10,7 @@ trim_trailing_whitespace = true
 indent_style = space
 indent_size = 4
 
-[*.xml]
+[*.{xml,xml.dist}]
 indent_style = tab
 indent_size = 4
 

.gitignore

@@ -1,2 +1,3 @@
+/.phpunit.result.cache
 /composer.lock
 /vendor/

.travis.yml

@@ -23,5 +23,6 @@ install:
 
 script:
   - "composer test:syntax -- --no-progress"
+  - "composer test:phpunit"
   - "composer test:cs -- -s"
   - "composer test:phpstan -- --ansi --memory-limit=1G --no-progress"

composer.json

@@ -19,8 +19,10 @@
     "require-dev": {
         "composer/composer": "^1.10.23",
         "dealerdirect/phpcodesniffer-composer-installer": "^0.7",
+        "nikic/php-parser": "< 4.13.0",
         "php-parallel-lint/php-parallel-lint": "^1.1",
         "phpstan/phpstan-strict-rules": "^0.12",
+        "phpunit/phpunit": "^7 || ^9",
         "szepeviktor/phpcs-psr-12-neutron-hybrid-ruleset": "^0.6"
     },
     "extra": {
@@ -38,9 +40,11 @@
     "scripts": {
         "test": [
             "@test:syntax",
+            "@test:phpunit",
             "@test:cs",
             "@test:phpstan"
         ],
+        "test:phpunit": "phpunit",
         "test:cs": "phpcs --standard=PSR12NeutronRuleset --exclude=PEAR.Commenting.ClassComment,PEAR.Commenting.FileComment,Generic.Files.LineLength bootstrap.php src/",
         "test:phpstan": "phpstan analyze",
         "test:syntax": "parallel-lint bootstrap.php src/"

extension.neon

@@ -45,7 +45,7 @@ services:
             - phpstan.broker.dynamicFunctionReturnTypeExtension
 parameters:
     bootstrapFiles:
-        - ../../php-stubs/wordpress-stubs/wordpress-stubs.php
+        - %rootDir%/../../php-stubs/wordpress-stubs/wordpress-stubs.php
         - bootstrap.php
     dynamicConstantNames:
         - WP_DEBUG

phpunit.xml.dist

@@ -0,0 +1,11 @@
+<phpunit
+	colors="true"
+	failOnRisky="true"
+	failOnWarning="true"
+>
+	<testsuites>
+		<testsuite name="main">
+			<directory suffix="Test.php">./tests/</directory>
+		</testsuite>
+	</testsuites>
+</phpunit>

src/GetCommentDynamicFunctionReturnTypeExtension.php

@@ -12,6 +12,7 @@
 use PhpParser\Node\Expr\FuncCall;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\Type;
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\StringType;
@@ -20,6 +21,7 @@
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\NullType;
 use PHPStan\Type\TypeCombinator;
+use PHPStan\Type\Constant\ConstantStringType;
 
 class GetCommentDynamicFunctionReturnTypeExtension implements \PHPStan\Type\DynamicFunctionReturnTypeExtension
 {
@@ -32,6 +34,20 @@ public function isFunctionSupported(FunctionReflection $functionReflection): boo
     public function getTypeFromFunctionCall(FunctionReflection $functionReflection, FuncCall $functionCall, Scope $scope): Type
     {
         $output = 'OBJECT';
+
+        if (count($functionCall->args) >= 2) {
+            $argumentType = $scope->getType($functionCall->args[1]->value);
+
+            // When called with an $output that isn't a constant string, return default return type
+            if (! $argumentType instanceof ConstantStringType) {
+                return ParametersAcceptorSelector::selectFromArgs(
+                    $scope,
+                    $functionCall->args,
+                    $functionReflection->getVariants()
+                )->getReturnType();
+            }
+        }
+
         if (count($functionCall->args) >= 2 && $functionCall->args[1]->value instanceof ConstFetch) {
             $output = $functionCall->args[1]->value->name->getLast();
         }

src/GetObjectTaxonomiesDynamicFunctionReturnTypeExtension.php

@@ -13,6 +13,7 @@
 use PhpParser\Node\Expr\FuncCall;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\FunctionReflection;
+use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\Type;
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\IntegerType;
@@ -39,12 +40,16 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 
         $argumentType = $scope->getType($functionCall->args[1]->value);
 
-        // When called with a non-string $output, return default return type
+        // When called with an $output that isn't a constant string, return default return type
         if (! $argumentType instanceof ConstantStringType) {
-            return new ArrayType(new IntegerType(), new StringType());
+            return ParametersAcceptorSelector::selectFromArgs(
+                $scope,
+                $functionCall->args,
+                $functionReflection->getVariants()
+            )->getReturnType();
         }
 
-        // Called with a string $output
+        // Called with a constant string $output
         switch ($argumentType->getValue()) {
             case 'objects':
                 return new ArrayType(new StringType(), new ObjectType('WP_Taxonomy'));

src/MySQL2DateDynamicFunctionReturnTypeExtension.php

@@ -33,7 +33,7 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
     {
         $argumentType = $scope->getType($functionCall->args[0]->value);
 
-        // When called with a non-string $format, return default return type
+        // When called with a $format that isn't a constant string, return default return type
         if (! $argumentType instanceof ConstantStringType) {
             return ParametersAcceptorSelector::selectFromArgs(
                 $scope,
@@ -42,7 +42,7 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
             )->getReturnType();
         }
 
-        // Called with a string $format
+        // Called with a constant string $format
         switch ($argumentType->getValue()) {
             case 'G':
             case 'U':

tests/bootstrap.php

@@ -0,0 +1,7 @@
+<?php
+
+declare(strict_types=1);
+
+error_reporting(E_ALL);
+
+require_once __DIR__ . '/../vendor/autoload.php';