Merge pull request #46 from johnbillion/fix/get-taxonomies-return-type

Author: szepeviktor

src/GetTaxonomiesDynamicFunctionReturnTypeExtension.php

@@ -1,5 +1,7 @@
 <?php
 
+//phpcs:disable SlevomatCodingStandard.Functions.UnusedParameter.UnusedParameter
+
 /**
  * Set return type of get_taxonomies().
  */
@@ -11,13 +13,12 @@
 use PhpParser\Node\Expr\FuncCall;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\FunctionReflection;
-use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\Type;
 use PHPStan\Type\ArrayType;
-use PHPStan\Type\IntegerType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\Constant\ConstantStringType;
+use PHPStan\Type\TypeCombinator;
 
 class GetTaxonomiesDynamicFunctionReturnTypeExtension implements \PHPStan\Type\DynamicFunctionReturnTypeExtension
 {
@@ -31,29 +32,32 @@ public function isFunctionSupported(FunctionReflection $functionReflection): boo
      */
     public function getTypeFromFunctionCall(FunctionReflection $functionReflection, FuncCall $functionCall, Scope $scope): Type
     {
+        $objectsReturnType = new ArrayType(new StringType(), new ObjectType('WP_Taxonomy'));
+        $namesReturnType = new ArrayType(new StringType(), new StringType());
+        $indeterminateReturnType = TypeCombinator::union(
+            $objectsReturnType,
+            $namesReturnType
+        );
+
         // Called without second $output arguments
         if (count($functionCall->args) <= 1) {
-            return new ArrayType(new IntegerType(), new StringType());
+            return $namesReturnType;
         }
 
         $argumentType = $scope->getType($functionCall->args[1]->value);
 
         // When called with a non-string $output, return default return type
         if (! $argumentType instanceof ConstantStringType) {
-            return ParametersAcceptorSelector::selectFromArgs(
-                $scope,
-                $functionCall->args,
-                $functionReflection->getVariants()
-            )->getReturnType();
+            return $indeterminateReturnType;
         }
 
         // Called with a string $output
         switch ($argumentType->getValue()) {
             case 'objects':
-                return new ArrayType(new IntegerType(), new ObjectType('WP_Taxonomy'));
+                return $objectsReturnType;
             case 'names':
             default:
-                return new ArrayType(new IntegerType(), new StringType());
+                return $namesReturnType;
         }
     }
 }