ASTDemangler: Round-trip @isolated @sil_implicit_leading_param parameter attributes #82533
+238
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
adrian-prantl,
rjmccall,
hborla,
xedin and
eeckstein
as code owners
slavapestov
force-pushed
the
fix-rdar153730847
branch
2 times, most recently
from
15cfb5f to
a91ae39
Compare
|
@swift-ci Please smoke test |
ktoso
reviewed
Jun 27, 2025
| case Node::Kind::ImplParameterSending: | ||
| options |= T::getSending(); | ||
| break; | ||
| break; |
There was a problem hiding this comment.
minor but seems like dupe/typo?
…ter attributes We sometimes mangle SILFunctionTypes when generating debug info for reabstraction thunks, and these can have various exotic parameter and result attributes. Two recent additions were never plumbed through the mangler, causing assertion failures when emitting debug info. Fixes rdar://153730847.
slavapestov
force-pushed
the
fix-rdar153730847
branch
from
a91ae39 to
9033198
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes mangle SILFunctionTypes when generating debug info for reabstraction thunks, and these can have various exotic parameter and result attributes. Two recent additions were never plumbed through the mangler, causing assertion failures when emitting debug info.
Fixes rdar://153730847.