Skip to content

[Concurrency] Rename Dummy(Main|Task)Executor. #82526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
al45tair merged 2 commits into from
Jul 3, 2025
Merged

[Concurrency] Rename Dummy(Main|Task)Executor. #82526

al45tair merged 2 commits into from
Jul 3, 2025

Conversation

@al45tair
Copy link
Contributor

@al45tair al45tair commented Jun 26, 2025

UnimplementedExecutor seems like a better name.

rdar://153531418

al45tair added 2 commits June 26, 2025 10:55
@al45tair
[Concurrency] Rename Dummy(Main|Task)Executor.
0dde6a5 
`UnimplementedExecutor` seems like a better name.

rdar://153531418
@al45tair
[Build][Concurrency] Update new runtime build as well.
aab0e44 
We need to update the new runtime build with the filename change also.

rdar://153531418
@al45tair al45tair requested a review from a team as a code owner June 26, 2025 09:56
@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Jun 26, 2025
@al45tair
Copy link
Contributor Author

al45tair commented Jun 26, 2025 •
edited
Loading

Explanation: Renames "Dummy(Task|Main)Executor".
Risk: Low. Only affects places that used Dummy(Task|Main)Executor, and it's only a name change at that.
Original PR: #82417
Reviewed by: @ktoso, @compnerd, @franklinsch
Resolves: rdar://153531418
Tests: Unimplemented(Task|Main)Executor is only really used as a fallback for certain types of build and will fatalError() if called. While it will be API, it's currently only really used by the runtime itself, and only for certain kinds of build.

@al45tair
Copy link
Contributor Author

al45tair commented Jun 26, 2025

@swift-ci Please test

@al45tair al45tair merged commit 2323449 into swiftlang:release/6.2 Jul 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbkka tbkka tbkka approved these changes

Assignees

No one assigned

Labels

🍒 release cherry pick Flag: Release branch cherry picks swift 6.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@al45tair @tbkka