[6.2🍒] fix calls to llvm prefix mapping functions to use space-separated option format #82513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted option format
|
Please test with the following pull request: @swift-ci please test |
|
Please test with the following pull request: @swift-ci please test Windows platform |
bnbarham
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Use the new space-separated format for the
-fdepscan-prefix-mapflag when calling LLVM from Swift, as well as using the new API used to implement that option which usesstd::pairinstead of single strings.Scope: This should not cause any backward compatibility issues since it is not changing any option for Swift itself, it is just adjusting it to use the new option introduced in swiftlang/llvm-project#10740.
Issues: rdar://129434789
Original PRs: #81792
Risk: Low, does not change Swift's API or CLI flags.
Testing: The new functionality is implemented and tested in the corresponding LLVM PR swiftlang/llvm-project#10740, there are no tests added in this PR.
Reviewers: @akyrtzi @cachemeifyoucan @benlangmuir