Fix toolchain stack equality checks when checking if specialized targets are compatible #615
+54
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ets are compatible
owenv
requested review from
aciidgh,
jakepetroules,
mirza-garibovic,
mhrawdon and
neonichu
as code owners
|
@swift-ci test |
|
@swift-ci test macOS |
|
@swift-ci test Linux |
|
@swift-ci test macOS |
jakepetroules
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the downloadable Metal toolchain is installed in Xcode, it could cause specialization compatibility checks to fail, causing downstream errors specializing targets representing package plugins. This happened because the compatibility check compared the
toolchainsofSpecializationParameterswith theTOOLCHAINSmacro in the configured target's settings. We should usesettings.toolchainson the RHS instead to ensure both sides of the comparison have a chance to inject the default toolchain during settings construction.Closes #614
Closes #570