Snippet and tests syncing #3925
Conversation
| ) | ||
|
|
||
| var ( | ||
| testsCmd = &cobra.Command{ |
There was a problem hiding this comment.
We already have a test root command that we can enrich https://github.com/supabase/cli/blob/develop/cmd/test.go
| "favorite": false, | ||
| "schema_version": schemaVersion, | ||
| "sql": sql, | ||
| } |
There was a problem hiding this comment.
Let's fix the openapi type so this can be a properly generated struct.
I'd also use multipart/form upload for sql snippets to avoid string escape issues when converting sql function to json.
|
|
||
| const ( | ||
| ContentTypeTest ContentType = "test" | ||
| ContentTypeSnippet ContentType = "snippet" |
There was a problem hiding this comment.
we can reuse the generated enums for api.UpsertContentBodyType to simplify type conversion
| Visibility: api.UpsertContentBodyVisibilityProject, | ||
| Content: &content, | ||
| } | ||
| resp, err := utils.GetSupabase().V1ProjectUpsertSnippetWithResponse(ctx, flags.ProjectRef, id, body) |
There was a problem hiding this comment.
upsert really means update or insert. The operation id for this openapi spec should be v1-project-update-snippet for clarity
| if !isCorrectType(s.Type, contentType) || s.Visibility != api.SnippetListDataVisibilityProject { | ||
| continue | ||
| } | ||
| id, err := uuid.Parse(s.Id) |
There was a problem hiding this comment.
update openapi response type to uuid to avoid this client side conversion loop
| return nil | ||
| } | ||
|
|
||
| func DownloadAll(ctx context.Context, fsys afero.Fs, contentType ContentType) error { |
There was a problem hiding this comment.
I'd suggest breaking this up
ListSnippets(ctx context.Context, contentType ContentType)DownloadSnippets(ctx context.Context, snippetIds []uuid.UUID, fsys afero.Fs)
There's no need to have a separate DownloadOne since we can use a single element array.
This adds commands for downloading and pushing "snippets" to remote (dashboard). As part of database testing work, a snippet can either by "sql" (e.g. in sql editor) or "tests". A test is an sql file that makes use of pgTap. https://supabase.com/docs/guides/database/testing
tests downloaddownloads project snippets of type test to thetests/databasefolder.snippets downloaddownloads project snippets of type sql to the snippets folder.Infrastructure PR https://github.com/supabase/infrastructure/pull/24519
Studio PR supabase/supabase#37499