Skip to content

Camberline Hicks-Henne Parameterization as design feature #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

JanRotti
Copy link
Contributor

@JanRotti JanRotti commented Jul 15, 2025

Proposed Changes

I added a purely camberline driven parameterization to the design features.

Starting of from some reference airfoil geometry the thickness is fixed. The camberline is parameterized via hicks-henne bump functions.

  • The parameterization always assumes a flat camberline when the bumps are set to 0.
  • The deformation also works with blunt trailing edges
  • The thickness distribution is kept from the reference geomentry
  • The deformation should work for arbitrary airfoil placement (not tested); (except for specific constellations when the tangent at the trailing edge is 'more vertical than horizontal')

I tested this with two NACA configurations (one with blunt trailing edge), I did not add these files due to the file size of the meshes.

Related Work

X

Reasoning

It presents a simplified design feature to test optimization methods. This is not intended as serious design feature!

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, can you add an example and regression test, maybe a version or a modification of one of the cases in TestCases/deformation

@JanRotti
Copy link
Contributor Author

The failing of CodeFactor I feel is irrelevant, I tried copying the previous regression test syntax (white-space etc.), which is now producing the fail.

For the regression test, I do not quite understand what exactly I should test. When I run the test myself and inspect the deformed mesh, there is a slight bump at the trailing edge (expected behavior for the design definition). I currently have the values set simply from manually running SU2_DEF and inserting the the residual value after 10 iterations as reference. I used the triangular NACA0012 mesh from the Quickstart for the test.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after addressing the comments 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants