feature(graph): Allow cyclic graphs #497
Open
+805
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrayy
reviewed
Jul 18, 2025
7 tasks
|
Please concider #571 |
Unshure
reviewed
Jul 31, 2025
Unshure
reviewed
Jul 31, 2025
Co-authored-by: Nick Clegg <nac542@gmail.com>
| def should_continue( | ||
| self, | ||
| max_node_executions: Optional[int], | ||
| execution_timeout: Optional[float], |
There was a problem hiding this comment.
Do you think we should have a default timeout value?
| @@ -213,8 +270,48 @@ def set_entry_point(self, node_id: str) -> "GraphBuilder": | |||
| self.entry_points.add(self.nodes[node_id]) | |||
| return self | |||
|
|
|||
| def reset_on_revisit(self, enabled: bool = True) -> "GraphBuilder": | |||
There was a problem hiding this comment.
nit: if the only purpose of this function is to True, then having a boolean parameter is unnecessary?
| if any(colors[node_id] == WHITE and has_cycle_from(node_id) for node_id in self.nodes): | ||
| raise ValueError("Graph contains cycles - must be a directed acyclic graph") | ||
| # Warn about potential infinite loops if no execution limits are set | ||
| if self._max_node_executions is None and self._execution_timeout is None: |
There was a problem hiding this comment.
Do you think we could help users avoid infinite loops?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the cyclic graph validation from the multiagent graph implementation, based on customer feedback. Previously, the graph implementation enforced a Directed Acyclic Graph (DAG) structure, which limited certain use cases. By removing this restriction, we now support cyclic graphs, enabling more flexible agent workflows such as:
The changes are minimal and focused on removing the cycle detection algorithm while maintaining all other validation checks.
Related Issues
Addresses customer feedback requesting support for cyclic agent graphs
Documentation PR
TODO
Type of Change
New feature
Testing
hatch testandhatch run test-integto ensure no regressionsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.