Skip to content

Conversation

@Amansingh0807
Copy link
Contributor

@Amansingh0807 Amansingh0807 commented Dec 15, 2025

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/base/ndarray/drev

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • Resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Implementation Notes:

  • Wrapper Strategy: This package acts as an ndarray interface layer. It extracts the underlying data buffer, stride, and offset from the input ndarray and delegates the reversal logic to the base strided implementation.

  • API Consistency: The function signature is drev( x ) (unary operator), consistent with standard BLAS conventions for in-place modifications, rather than accepting an array of arrays.

  • Stride & Edge Case Handling: Relies on the robust handling within the base @stdlib/blas/ext/base/drev package for negative strides and empty arrays (N=0).

  • Type: Validated for double-precision floating-point performance (Float64Array) in benchmarks.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

- Add ndarray wrapper for drev function
- Implement comprehensive test suite with stride/offset tests
- Add documentation (README, REPL, TypeScript types)
- Add examples and performance benchmarks
- Follow stdlib conventions for BLAS operations
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 15, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 15, 2025

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray/drev $\color{green}101/101$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}101/101$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.


// The function returns an ndarray...
{
const Float64Array = require( '@stdlib/array/float64' );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No imports in blocks like this. See other packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. I've updated docs/types/test.ts to use top-level imports, consistent with other packages. Ready for review.

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants