Improve invalid backend error #626
Open
+59
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #626 +/- ##
==========================================
+ Coverage 96.97% 97.19% +0.21%
==========================================
Files 29 29
Lines 1948 1958 +10
==========================================
+ Hits 1889 1903 +14
+ Misses 59 55 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenGalewsky
approved these changes
Jul 15, 2025
|
Why is this in draft mode? |
|
Because I was waiting for the tests to finish to make sure there wasn't a failure!! |
* Improve backend error message * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
gordonwatts
force-pushed
the
codex/list-valid-backend-names-in-error-message
branch
from
5768488 to
c73b30b
Compare
|
Here is what it looks like now: |
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling in the ServiceX client by enhancing error messages for invalid backend specifications and configuration loading issues. The changes make error messages more helpful by providing specific file paths and listing available backends to help users fix configuration problems.
- Enhanced error messages for invalid backend names to include the config file path and list valid options
- Added tracking of configuration file paths through the Configuration class
- Added comprehensive test coverage for the new error handling functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| servicex/configuration.py | Modified to track and return config file paths, updated _add_from_path method to return both config and file path |
| servicex/servicex_client.py | Enhanced error message for invalid backends to include config file path and list of valid backend names |
| tests/test_servicex_client.py | Added test to verify error message includes filename when invalid backend is specified |
| tests/test_config.py | Added parameterized test to verify config can be read from default files (servicex.yaml and .servicex) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notes
codexhttps://chatgpt.com/codex/tasks/task_e_6876c3822040832089f2687e0926f63b