-
Notifications
You must be signed in to change notification settings - Fork 13
Update production workflow for full uv #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #623 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 29 29
Lines 1939 1939
=======================================
Hits 1871 1871
Misses 68 68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the CI production workflow to consistently use the uv
CLI for virtual environment management and package installation, and to run example scripts within that environment.
- Added a
uv venv
step to create a virtual environment before installing dependencies. - Removed the
--system
flags and updated pip install/list commands to run inside the venv. - Changed example execution to invoke the script via
uv run python ...
for consistent environment usage.
Comments suppressed due to low confidence (3)
.github/workflows/ci_production.yaml:35
- [nitpick] Rename the
uv venv
step to something more descriptive like 'Setup virtual environment' to improve readability.
uv venv
.github/workflows/ci_production.yaml:34
- [nitpick] Consider using the official actions/setup-python action with caching enabled instead of custom
uv
commands; this can make the workflow more maintainable and consistent across projects.
run: |
.github/workflows/ci_production.yaml:41
- [nitpick] Include
--
before the command (e.g.,uv run -- python UprootRaw_Dict.py
) to clearly separate uv flags from the script invocation and avoid potential parsing issues.
run: uv run python UprootRaw_Dict.py
uv pip install --system --upgrade '.[test]' | ||
uv pip list --system | ||
uv venv | ||
uv pip install --upgrade '.[test]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add --no-cache-dir
to the pip install command (e.g., uv pip install --no-cache-dir --upgrade '.[test]'
) to reduce cache overhead and speed up CI runs.
uv pip install --upgrade '.[test]' | |
uv pip install --no-cache-dir --upgrade '.[test]' |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like the --no-cache-dir
Use uv consistently in a virtual environment for production test