Support Kotlin Context Parameters #35428
Open
+75
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: SIMULATAN <jakob@simulatan.me>
SIMULATAN
force-pushed
the
fix/coroutinesutils-context-parameters
branch
from
d5a1da2 to
99fa9dd
Compare
|
Could you please add related test(s)? |
sdeleuze
added
the
status: waiting-for-feedback
Signed-off-by: SIMULATAN <jakob@simulatan.me>
SIMULATAN
force-pushed
the
fix/coroutinesutils-context-parameters
branch
from
11ed8e7 to
e69b67b
Compare
|
Added tests in a fixup commit, analogous to the existing Kotlin Extension Function tests. Had to force-push once as I messed up the GPG signing on my work device. Let me know in case any further modifications are wanted. |
spring-projects-issues
added
status: feedback-provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: finding a commit message for this change is quite difficult, the current one is likely to cause confusion. I'd appreciate better suggestions
Originally introduced as Beta in 2.2.0, Context Parameters are a new Kotlin feature that I wanted to use in my project.
Those parameters have a different
KParameter.Kind(CONTEXT) and are therefore not supported by the current CoroutinesUtils implementation. This resulted in the following error message:Status
kotlin-reflect's Context Parameters support was first released in 2.2.20-Beta1. Therefore, I had to target the latest 2.2.20 RC with this PR.Once 2.2.20 is formally released, I'll await the update on Spring's main branch, rebase onto it, and set the PR as ready to merge.With 86fb62c, main is using the latest Kotlin release. I've done the rebase and marked the PR as ready to review. Thanks in advance for your considerations!