fix: support BYOT OAuth mode without requiring service URLs #699
+225
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: "com.atlassian.confluence.api.service.exceptions.GoneException: This deprecated endpoint has been removed." error when using ATLASSIAN_OAUTH_ENABLE (BYOT) + Atlassian Cloud. **Changes:** - Allow missing CONFLUENCE_URL/JIRA_URL when ATLASSIAN_OAUTH_ENABLE is set - Mark services as available in environment detection for BYOT mode - Preserve original is_cloud behavior based on oauth_config.cloud_id presence **Configuration behavior:** - ATLASSIAN_OAUTH_ENABLE=true + no URLs → creates minimal OAuth config - is_cloud determination depends on ATLASSIAN_OAUTH_CLOUD_ID presence: - With ATLASSIAN_OAUTH_CLOUD_ID → is_cloud = True (Cloud API) - Without ATLASSIAN_OAUTH_CLOUD_ID → is_cloud = False (Server API) - When URLs are provided, they override cloud detection as before **Files modified:** - src/mcp_atlassian/confluence/config.py - src/mcp_atlassian/jira/config.py - src/mcp_atlassian/utils/environment.py **Tests added:** - BYOT OAuth scenarios with/without URLs and cloud_id - Environment service detection for minimal OAuth mode - Various ATLASSIAN_OAUTH_ENABLE value format validation This enables BYOT (Bring Your Own Token) OAuth deployments where user tokens are provided via HTTP headers without requiring static service URL configuration, while maintaining backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #698
Changes
Testing
Checklist