Skip to content

fix: Fix sub-task creation compatability with Jira 9+ #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −10
Open

fix: Fix sub-task creation compatability with Jira 9+ #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22a523a
fix: Fix sub-task creation compatability with Jira 9+
Jul 8, 2025
b056400
test: Update test to account for sub-task creation compatability fix
Jul 8, 2025
5e7d100
test: Update to pass linting
Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mcp_atlassian/jira/projects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,9 +250,9 @@ def get_project_issue_types(self, project_key: str) -> list[dict[str, Any]]:
List of issue type data dictionaries
"""
try:
meta = self.jira.issue_createmeta(project=project_key)
meta = self.jira.issue_createmeta_issuetypes(project=project_key)
if not isinstance(meta, dict):
msg = f"Unexpected return value type from `jira.issue_createmeta`: {type(meta)}"
msg = f"Unexpected return value type from `jira.issue_createmeta_issuetypes`: {type(meta)}"
logger.error(msg)
raise TypeError(msg)

Expand Down
18 changes: 10 additions & 8 deletions tests/unit/jira/test_projects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,25 +425,27 @@ def test_get_project_issue_types(
{"key": "PROJ1", "name": "Project One", "issuetypes": mock_issue_types}
]
}
projects_mixin.jira.issue_createmeta.return_value = createmeta
projects_mixin.jira.issue_createmeta_issuetypes.return_value = createmeta

result = projects_mixin.get_project_issue_types("PROJ1")
assert result == mock_issue_types
projects_mixin.jira.issue_createmeta.assert_called_once_with(project="PROJ1")
projects_mixin.jira.issue_createmeta_issuetypes.assert_called_once_with(
project="PROJ1"
)


def test_get_project_issue_types_empty_response(projects_mixin: ProjectsMixin):
"""Test get_project_issue_types method with empty response."""
# Empty projects list
projects_mixin.jira.issue_createmeta.return_value = {"projects": []}
projects_mixin.jira.issue_createmeta_issuetypes.return_value = {"projects": []}

result = projects_mixin.get_project_issue_types("PROJ1")
assert result == []
projects_mixin.jira.issue_createmeta.assert_called_once()
projects_mixin.jira.issue_createmeta_issuetypes.assert_called_once()

# No issuetypes field
projects_mixin.jira.issue_createmeta.reset_mock()
projects_mixin.jira.issue_createmeta.return_value = {
projects_mixin.jira.issue_createmeta_issuetypes.reset_mock()
projects_mixin.jira.issue_createmeta_issuetypes.return_value = {
"projects": [{"key": "PROJ1", "name": "Project One"}]
}

Expand All @@ -453,11 +455,11 @@ def test_get_project_issue_types_empty_response(projects_mixin: ProjectsMixin):

def test_get_project_issue_types_exception(projects_mixin: ProjectsMixin):
"""Test get_project_issue_types method with exception."""
projects_mixin.jira.issue_createmeta.side_effect = Exception("API error")
projects_mixin.jira.issue_createmeta_issuetypes.side_effect = Exception("API error")

result = projects_mixin.get_project_issue_types("PROJ1")
assert result == []
projects_mixin.jira.issue_createmeta.assert_called_once()
projects_mixin.jira.issue_createmeta_issuetypes.assert_called_once()


def test_get_project_issues_count(projects_mixin: ProjectsMixin):
Expand Down
Loading