-
Notifications
You must be signed in to change notification settings - Fork 633
feat: Add ability to move issues to a sprint #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add ability to move issues to a sprint #566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @jeteve I left some comments
This pull request has been automatically marked as stale because it has not had recent activity for 14 days. It will be closed if no further activity occurs. Please leave a comment or remove the 'stale' label if you believe this PR is still relevant. Thank you for your contributions! |
…s resolving this [comment](sooperset#566 (comment))
…udenfranz/mcp-atlassian into feature/move-issue-to-sprint
…error handling](sooperset#566 (comment)) and this [comment about adding tests](sooperset#566 (comment)) add_issues_to_sprint - added input validatlon - removed HTTPError exeption handling as underlying library does this - kept unexpected Error handling - added new tests: - - test_add_issues_to_sprint_invalid_sprint_id - - test_add_issues_to_sprint_empty_list - - test_add_issues_to_sprint_invalid_issues_type
Eliminates duplicate functionality since moving a single issue to a sprint is already handled by the existing add issues to sprint method. Simplifies the API by reducing method redundancy and maintains the same functionality through the more general bulk operation method.
Enables comprehensive testing of Jira sprint functionality by adding test for issue-to-sprint assignment workflow. Fixes missing site_metadata parameter in Confluence preprocessor to maintain API consistency.
I added also a test, to test against the real api in tests/test_real_api_validation.py :
|
For running the tests I had to add a file conftest.py (NOT included now in commits). """This file is used to configure pytest"""
import pytest
from dotenv import load_dotenv
@pytest.fixture(scope="session", autouse=True)
def load_env():
"""Load environment variables from .env file before tests run"""
load_dotenv() |
Also one test failed and could be fixed by adding site_metadata={} to # Create a converter
converter = ConfluenceStorageFormatConverter(
options=options,
path=Path(temp_dir) / "temp.md",
root_dir=Path(temp_dir),
page_metadata={},
site_metadata={},
) I also did not add this to my commits. |
This commit addresses linting and formatting issues identified by the `pre-commit` hooks. The changes include: - Removing unused imports - Correcting import order - Applying consistent code formatting across multiple files These changes ensure the codebase adheres to the project's style guidelines and passes all pre-commit checks.
This pull request has been automatically marked as stale because it has not had recent activity for 14 days. It will be closed if no further activity occurs. Please leave a comment or remove the 'stale' label if you believe this PR is still relevant. Thank you for your contributions! |
Changes
add_issues_to_sprint
tool to the Jira server.add_issues_to_sprint
method in theSprintsMixin
.JiraSprintInfo
model.Notes on Integration Tests
The integration test suite in the base project has several issues that prevent it from running successfully without modification. The following changes were made to the local environment to get the tests to pass:
pytest
fixture totests/conftest.py
to load the.env
file.tests/test_real_api_validation.py
to use theJIRA_TEST_ISSUE_KEY
andJIRA_TEST_PROJECT_KEY
environment variables.tests/test_real_api_validation.py
to handle the API responses correctly.These changes have been reverted in this branch, but they will be necessary for anyone who wants to run the integration tests.