Skip to content

Diamond Helper Functions #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Diamond Helper Functions #158

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
a7edda4
diamond utils draft
0xCourtney Nov 10, 2022
420964c
Merge branch 'master' into diamond-helper
ItsNickBarry Dec 14, 2022
047964e
remove printDiamond
0xCourtney Dec 11, 2022
9d3a62d
removes composite type
0xCourtney Dec 11, 2022
9d3b060
exports facet cut action
0xCourtney Dec 11, 2022
20bf78e
removes cli-table3 package
0xCourtney Dec 11, 2022
b2eda57
imports ethersproject packages
0xCourtney Dec 11, 2022
398ff37
Revert "remove printDiamond"
0xCourtney Dec 14, 2022
f9a6c2c
removes printDiamond from external interface
0xCourtney Dec 14, 2022
45b2dc4
throws if add/replace/remove fails
0xCourtney Dec 14, 2022
3d9d456
adds only filter, refactors exclude
0xCourtney Dec 19, 2022
e702c36
adds previewFacetCut
0xCourtney Dec 19, 2022
5f34d05
removes printDiamond
0xCourtney Dec 19, 2022
1aa7db8
adds comments
0xCourtney Dec 20, 2022
f00863e
capitalize FacetCutAction enum types
ItsNickBarry Dec 20, 2022
c8195bc
moves diamond utils to diamond subdirectory
0xCourtney Dec 20, 2022
f43c14a
Merge branch 'diamond-helper' of github.com:solidstate-network/solids…
ItsNickBarry Dec 20, 2022
c93c0a5
Merge branch 'master' into diamond-helper
ItsNickBarry Dec 20, 2022
e5d19a2
use FacetCutAction enum in spec and test files
ItsNickBarry Dec 20, 2022
dfac641
fix dependency versions
ItsNickBarry Dec 20, 2022
669a620
Merge pull request #176 from solidstate-network/diamond-helper-enum-e…
ItsNickBarry Dec 20, 2022
cef5a3f
reorder declarations
ItsNickBarry Dec 20, 2022
ce286c6
uses except instead of exclude
0xCourtney Dec 20, 2022
a2a3c19
Update lib/diamond/utils.ts
0xCourtney Dec 22, 2022
c7df310
Update lib/diamond/utils.ts
0xCourtney Dec 22, 2022
7d6598e
Update lib/diamond/filters.ts
0xCourtney Dec 22, 2022
9d92ea0
rename
0xCourtney Dec 22, 2022
a9b12a5
updates comments
0xCourtney Dec 22, 2022
f4c211b
rename
0xCourtney Dec 22, 2022
dbf11d5
typo
0xCourtney Dec 22, 2022
871f868
diamonCut returns receipt
0xCourtney Dec 22, 2022
54da442
consolidates only and execpt to single array, adds type and action to…
0xCourtney Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/diamond/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,15 @@ export interface FacetCut extends Facet {
}

// returns a list of signatures for a contract
export function getSignatures(contract: Contract): string[] {
export function getFuntionSignatures(contract: Contract): string[] {
return Object.keys(contract.interface.functions);
}

// returns a list of selectors for a contract
export function getSelectors(contract: Contract): string[] {
return getSignatures(contract).map((signature) => contract.interface.getSighash(signature));
return getFuntionSignatures(contract).map((signature) =>
contract.interface.getSighash(signature),
);
}

// returns a list of Facets for a contract
Expand Down