chore: test with old python version #71
Conversation
📝 WalkthroughWalkthroughA new workflow job was added to test the minimum Python version environment, and the explicit Pixi version was removed from workflow jobs. Additionally, a test for Snakemake version checking was moved from an existing test file to a dedicated new test file, with no other changes to test logic. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Code Checkout
participant Pixi Installer
participant Test Runner
GitHub Actions->>Code Checkout: Checkout repository
GitHub Actions->>Pixi Installer: Install Pixi (env: minpyver)
GitHub Actions->>Test Runner: Run tests for min Python version
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/test.yml (1)
59-70: LGTM! Fix missing newline at end of file.The new
test-min-pythonjob structure is consistent with existing jobs and properly uses theminpyverenvironment for testing minimum Python version compatibility.- name: Run tests with min python - run: pixi run --environment minpyver test-min-python -v + run: pixi run --environment minpyver test-min-python -v +
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pyproject.tomlis excluded by!pyproject.toml
📒 Files selected for processing (3)
.github/workflows/test.yml(1 hunks)tests/test_snakemake_dependent.py(1 hunks)tests/tests.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.py`: Do not try to improve formatting. Do not suggest type annotations for functions that are defined inside of functions or methods. Do not suggest type annotation of the `s...
**/*.py: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of theselfargument of methods.
Do not suggest type annotation of theclsargument of classmethods.
Do not suggest return type annotation if a function or method does not contain areturnstatement.
tests/tests.pytests/test_snakemake_dependent.py
🪛 YAMLlint (1.37.1)
.github/workflows/test.yml
[error] 70-70: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (2)
tests/tests.py (1)
72-72: LGTM!The method call is correct and the reorganization of Snakemake-specific tests to a dedicated file is a good practice.
tests/test_snakemake_dependent.py (1)
4-6: ```shell
#!/bin/bashInspect Pixi configuration for the minpyver environment and test-min-python task
rg -A5 -B5 "[tool.pixi]" pyproject.toml
rg -A5 -B5 "test-min-python" pyproject.toml</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Summary by CodeRabbit