Improve logging on rejected packets #998
Merged
+39
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
force-pushed
the
chore/better-logging-rejected-packets
branch
from
0bbb00f to
c5b706a
Compare
crawford
reviewed
Oct 16, 2024
|
Thank you, this is indeed helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent a bunch of time debugging why my packets weren't processed by
smoltcp. After I finally found the code that performs these checks, I figured that these boolean conditions were quite hard to understand, so I split them up. This made it quite easy to add log statements that should guide the user to the problem as to why their packets aren't being processed.