feat: add support for --profile and --features flags #2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for custom build profiles and features in cargo-shuttle run command: - Add --profile flag to specify custom build profiles (e.g., --profile production) - Add --features flag to specify cargo features (e.g., --features "feature1 feature2") - Ensure --profile conflicts with --release to avoid confusion - Properly combine custom features with existing "shuttle" feature when present This allows users to have more control over the build process, matching the flexibility of standard cargo commands.
|
clippy is failing cause there are too many arguments to a function that i modified to support this new feature. Should I refactor that into a struct? |
|
For context I need this feature to test my project with dhat without having to edit each time my project's Cargo.toml file |
|
Thanks for the idea! I'll think about how this should work regarding the default shuttle feature, and look at how we can support it in the deploy command and Shuttle.toml too. Then it could perhaps be part of the next release. |
|
Sorry for the delay on this. After resolving conflicts, it would be good to populate these fields in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces:
shuttle run --profile [profile]which builds the runtime with a custom cargo profile, just likecargo build --profile [profile]does.Cargo.toml(e.g.,--profile production,--profile bench)--releaseflag to avoid confusionshuttle run --features [features]which enables specific cargo features during build.--features "feature1 feature2"or--features feature1,feature2)cargo build --featuresThis allows users to have more control over the build process, matching the flexibility of standard cargo commands. Particularly useful for:
Cargo.toml