Skip to content

Delete comments in script.sh #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Delete comments in script.sh #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf1bba0
It makes more sense to use Docker installed on your runner.
shmokmt Oct 23, 2024
22e43de
Add a note section
shmokmt Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,9 @@ jobs:
github_token: ${{ secrets.github_token }}
```

>[!NOTE]
> We recommend using Ubuntu, the GitHub self hosted runner. This action assumes that Docker and buildx are already installed on your system. If your runner does not have these pre-installed, please set them up yourself.

## See Also
* https://docs.docker.com/reference/build-checks/
* https://github.com/actions/runner-images/
8 changes: 0 additions & 8 deletions script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,6 @@ export REVIEWDOG_GITHUB_API_TOKEN="${INPUT_GITHUB_TOKEN}"
TEMP_PATH="$(mktemp -d)"
PATH="${TEMP_PATH}:$PATH"

# echo "::group:: Installing Docker..."
# # Re-install Docker Engine
# for pkg in docker.io docker-doc docker-compose docker-compose-v2 podman-docker containerd runc; do sudo apt-get remove $pkg; done
# # Install from official script
# curl -fsSL https://get.docker.com -o get-docker.sh
# sudo sh get-docker.sh
# echo "::endgroup"

echo "::group:: docker version"
docker version
echo "::endgroups::"
Expand Down