Skip to content

Init for docker-build-check #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

shmokmt
Copy link
Owner

@shmokmt shmokmt commented Oct 20, 2024

No description provided.

@shmokmt shmokmt force-pushed the feature/docker-build-check branch 13 times, most recently from 56d30ca to b4ff5ef Compare October 23, 2024 09:47
@@ -0,0 +1,3 @@
FROM alpine as test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [docker-build-check] <FromAsCasing> reported by reviewdog 🐶
The 'as' keyword should match the case of the 'from' keyword

@@ -0,0 +1,3 @@
FROM alpine as test

CMD echo "Hello, World!"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [docker-build-check] <JSONArgsRecommended> reported by reviewdog 🐶
JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals

@shmokmt shmokmt force-pushed the feature/docker-build-check branch 2 times, most recently from 2fe2f30 to 462d3d5 Compare October 23, 2024 10:31
@shmokmt shmokmt force-pushed the feature/docker-build-check branch from 462d3d5 to 1bd5c5e Compare October 23, 2024 10:42
@shmokmt shmokmt merged commit 17b06e1 into master Oct 23, 2024
2 checks passed
@shmokmt shmokmt deleted the feature/docker-build-check branch October 23, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant