-
Notifications
You must be signed in to change notification settings - Fork 22
Enable Claude Code Agent Action #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Strange that the CI is broken. The changes should not have any impact on CI. @ccummingsNV is there some intermittent issue at play here? |
@szihs the CI has an intermittent (and unfortunately rather frequent) errors in that test that @ccummingsNV is investigating. |
can you then review the PR @tdavidovicNV ? |
@szihs what is this based off? Should we copy/paste the workflow across multiple repos like this or share it using a github action instead? And what is that workflow doing? Some description or references would be good. |
@skallweitNV - Most of the heavy work is already done by using claude-code-action. You should be able to assign issues to @claude - for example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need some instruction of how to clone slang repo as well.
When the issue is coming from slang rather than slangpy, LLM will have to deal with slang as well.
Or we can just clone slang as a part of the claude.yml??
```bash | ||
# Install from source (recommended) | ||
pip install . | ||
|
||
# Configure and build with CMake | ||
python tools/ci.py configure | ||
python tools/ci.py build | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document also mentions the following instruction.
https://slangpy.shader-slang.org/en/latest/
pip install -r requirements-dev.txt
Don't we need it here?
```bash | ||
# Run Python unit tests | ||
pytest slangpy/tests -ra | ||
# Or via CI tool | ||
python tools/ci.py unit-test-python -p | ||
|
||
# Run example tests | ||
pytest samples/tests -vra | ||
|
||
# Run C++ unit tests | ||
python tools/ci.py unit-test-cpp | ||
|
||
# Run a single test | ||
pytest slangpy/tests/test_buffer.py::test_buffer_creation -v | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The testing commands look a little different from how CI does.
https://github.com/shader-slang/slangpy/blob/main/.github/workflows/ci.yml
Are those instructions correct and functional?
No description provided.