Skip to content

Enable Claude Code Agent Action #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

szihs
Copy link
Collaborator

@szihs szihs commented Jul 22, 2025

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2025

CLA assistant check
All committers have signed the CLA.

@szihs
Copy link
Collaborator Author

szihs commented Jul 22, 2025

Strange that the CI is broken. The changes should not have any impact on CI. @ccummingsNV is there some intermittent issue at play here?

@tdavidovicNV
Copy link
Contributor

@szihs the CI has an intermittent (and unfortunately rather frequent) errors in that test that @ccummingsNV is investigating.

@szihs
Copy link
Collaborator Author

szihs commented Jul 28, 2025

@szihs the CI has an intermittent (and unfortunately rather frequent) errors in that test that @ccummingsNV is investigating.

can you then review the PR @tdavidovicNV ?

@skallweitNV
Copy link
Contributor

@szihs what is this based off? Should we copy/paste the workflow across multiple repos like this or share it using a github action instead? And what is that workflow doing? Some description or references would be good.

@szihs
Copy link
Collaborator Author

szihs commented Jul 29, 2025

@szihs what is this based off? Should we copy/paste the workflow across multiple repos like this or share it using a github action instead? And what is that workflow doing? Some description or references would be good.

@skallweitNV - Most of the heavy work is already done by using claude-code-action. You should be able to assign issues to @claude - for example
szihs#2 (comment)

Copy link
Contributor

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some instruction of how to clone slang repo as well.
When the issue is coming from slang rather than slangpy, LLM will have to deal with slang as well.

Or we can just clone slang as a part of the claude.yml??

Comment on lines +12 to +19
```bash
# Install from source (recommended)
pip install .

# Configure and build with CMake
python tools/ci.py configure
python tools/ci.py build
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document also mentions the following instruction.
https://slangpy.shader-slang.org/en/latest/

pip install -r requirements-dev.txt

Don't we need it here?

Comment on lines +22 to +36
```bash
# Run Python unit tests
pytest slangpy/tests -ra
# Or via CI tool
python tools/ci.py unit-test-python -p

# Run example tests
pytest samples/tests -vra

# Run C++ unit tests
python tools/ci.py unit-test-cpp

# Run a single test
pytest slangpy/tests/test_buffer.py::test_buffer_creation -v
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing commands look a little different from how CI does.
https://github.com/shader-slang/slangpy/blob/main/.github/workflows/ci.yml

Are those instructions correct and functional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants