Skip to content

Split components out into libraries for reuse with slang-vscode-extension #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 25, 2025
Merged

Split components out into libraries for reuse with slang-vscode-extension #157

merged 13 commits into from
Jul 25, 2025

Conversation

Devon7925
Copy link
Contributor

This splits out components of the project into reusable libraries so that code can be shared between this project and slang-vscode-extension.

@Devon7925 Devon7925 changed the title Fully working library split Split components out into libraries for reuse with slang-vscode-extension Jul 22, 2025
@Devon7925 Devon7925 mentioned this pull request Jul 22, 2025
Draft
2 tasks
@Devon7925 Devon7925 marked this pull request as ready for review July 23, 2025 00:05
@Devon7925 Devon7925 requested a review from natevm July 23, 2025 00:06
@Devon7925 Devon7925 requested a review from samestep July 23, 2025 23:53
samestep
samestep requested changes Jul 24, 2025
View reviewed changes
samestep
samestep reviewed Jul 24, 2025
View reviewed changes
samestep
samestep reviewed Jul 24, 2025
View reviewed changes
Copy link

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just wanted to mention a couple things about the package.json setup.

samestep
samestep reviewed Jul 24, 2025
View reviewed changes
@Devon7925 Devon7925 requested a review from samestep July 24, 2025 20:49
samestep
samestep approved these changes Jul 25, 2025
View reviewed changes
Copy link

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for making these changes, I appreciate that you were willing to use my suggestions.

@Devon7925 Devon7925 merged commit fc06c7e into shader-slang:main Jul 25, 2025
2 checks passed
@Devon7925 Devon7925 deleted the library-split branch July 25, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samestep samestep samestep approved these changes

@natevm natevm Awaiting requested review from natevm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Devon7925 @samestep