Skip to content

Fix wifi on clover #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: qcom-sdm660-6.15.y
Choose a base branch
from

Conversation

barni2000
Copy link

clover using different modem firmware from clover-plus it is called modemnm.

I have done some small clean ups in all clover dt.

@barni2000 barni2000 force-pushed the barni2000/clover-fix-wifi branch from 16bfe09 to 01e7e63 Compare July 30, 2025 15:13
@setotau
Copy link

setotau commented Jul 30, 2025

Regular clover should use sda660 msm-id then

@barni2000 barni2000 force-pushed the barni2000/clover-fix-wifi branch 2 times, most recently from 18ccf09 to c2324d8 Compare July 30, 2025 15:27
@minlexx
Copy link
Member

minlexx commented Jul 30, 2025

These are still present in dtbs-check

sdm660-xiaomi-clover-plus.dtb: / (xiaomi,clover-plus): qcom,board-id: False schema does not allow [[11, 0]]
sdm660-xiaomi-clover-plus.dtb: / (xiaomi,clover-plus): qcom,msm-id: False schema does not allow [[317, 0]]
...
sda660-xiaomi-clover.dtb: / (xiaomi,clover): qcom,board-id: False schema does not allow [[11, 0]]
sda660-xiaomi-clover.dtb: / (xiaomi,clover): qcom,msm-id: False schema does not allow [[324, 0]]

If you all for some reason still insist on keeping those deprecated IDs, instead of completely droppping them, then at least fix schema validation: add qcom,sdm660 to that list https://github.com/sdm660-mainline/linux/blob/qcom-sdm660-6.15.y/Documentation/devicetree/bindings/arm/qcom.yaml#L1247

And perhaps, sda660 as well

@setotau
Copy link

setotau commented Jul 30, 2025

Maybe we should drop these properties?

@setotau
Copy link

setotau commented Jul 30, 2025

I've commented out msm-id and board-id and my clover-plus boots fine. At least for clover-plus they are may be dropped completely.

@barni2000 barni2000 force-pushed the barni2000/clover-fix-wifi branch from c2324d8 to 569543d Compare July 30, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants