tests(all): bump go-vcr to v3.2.0 #4909
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
registry
Mia-Cross
force-pushed
the
tests_bump_go_vcr_to_v3
branch
3 times, most recently
from
0971de8 to
da7f5f1
Compare
# Conflicts: # internal/namespaces/inference/v1beta1/testdata/test-deployment-create-simple-deployment.cassette.yaml # internal/namespaces/inference/v1beta1/testdata/test-deployment-create-simple-deployment.golden # internal/namespaces/vpc/v2/testdata/test-get-private-network-simple.cassette.yaml
Mia-Cross
force-pushed
the
tests_bump_go_vcr_to_v3
branch
from
61681b3 to
d5a9323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-vcrintroduced a very helpfulSkipRequestLatencyoption on the recorder in version 3. This will allow us to replay cassettes a lot faster because interactions will not simulate the requests' duration anymore.This is a breaking change however, and we should re-record all cassettes with the new version.