fix contrast in credits footer #8718

hotzenklotz · 2025-06-25T11:03:13Z

Fix the contrast between background color and text in the credits footer.
Also adjust the height of two onboarding cards while at it.

Before

After

URL of deployed dev instance (used for testing):

https://___.webknossos.xyz

Steps to test:

Go to orga settings
Delete your orga
You will be redirected to set up a new orga
Inspect the footer
Setup a new orga in the onboarding view. The last page should have two cards of identical height

(Please delete unneeded items, merge only when none are left open)

Updated changelog
Updated migration guide if applicable
Updated documentation if applicable
Adapted wk-libs python client if relevant API parts change
Removed dev-only changes like prints and application.conf edits
Considered common edge cases
Needs datastore update after deployment

coderabbitai · 2025-06-25T11:05:16Z

📝 Walkthrough

## Walkthrough

This update modifies the height of an onboarding UI card, refactors a footer component to use Ant Design theming and removes routing wrappers, and applies formatting changes to CSS selectors for consistency. No changes were made to logic, exported entities (except for a footer export), or overall styling semantics.

## Changes

| Files/Paths                                         | Change Summary                                                                                   |
|----------------------------------------------------|------------------------------------------------------------------------------------------------|
| frontend/javascripts/admin/onboarding.tsx          | Increased "Skip" OptionCard height from 170 to 250 to match "Upload Dataset" card.              |
| frontend/javascripts/components/credits_footer.tsx | Wrapped content in Ant Design `ConfigProvider` with dark theme, removed routing wrappers, simplified export. |
| frontend/stylesheets/main.less                      | Reformatted CSS selectors for compactness and consistency; no changes to styling logic or values.|

## Suggested labels

`usability`

## Suggested reviewers

- philippotto  
- daniel-wer

## Poem

> A hop and a skip, the UI grows tall,  
> Cards now align, standing proud in the hall.  
> The footer’s gone dark, with a theme to delight,  
> While CSS lines march, all tidy and tight.  
> 🐇 With a twitch of my nose, I code through the night!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75762f2 and 6f63cf3.

📒 Files selected for processing (1)

frontend/stylesheets/main.less (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

frontend/stylesheets/main.less

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: build-smoketest-push
GitHub Check: backend-tests
GitHub Check: frontend-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

hotzenklotz · 2025-06-25T11:08:07Z

frontend/stylesheets/main.less

Auto-reformat on save

hotzenklotz · 2025-06-25T11:10:33Z

frontend/stylesheets/main.less

-      width: 25%;
-      max-width: 100px;
-    }
+  img {


This is the main change in this file.

MichaelBuessemeyer

Awesome,looking good, thanks for fixing the UI 🙏

…-footer

fix contrast in credits footer

a6da1d6

hotzenklotz self-assigned this Jun 25, 2025

hotzenklotz added frontend css Something frontend styling related labels Jun 25, 2025

hotzenklotz requested a review from knollengewaechs June 25, 2025 11:07

hotzenklotz commented Jun 25, 2025

View reviewed changes

frontend/stylesheets/main.less

Copy link

Member Author

hotzenklotz Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-reformat on save

CSS

75762f2

hotzenklotz commented Jun 25, 2025

View reviewed changes

frontend/stylesheets/main.less

width: 25%;

max-width: 100px;

}

img {

Copy link

Member Author

hotzenklotz Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change in this file.

hotzenklotz requested a review from MichaelBuessemeyer July 1, 2025 18:23

MichaelBuessemeyer approved these changes Jul 2, 2025

View reviewed changes

Merge branch 'master' of github.com:scalableminds/webknossos into fix…

6f63cf3

…-footer

hotzenklotz enabled auto-merge (squash) July 2, 2025 09:51

hotzenklotz merged commit 56e8306 into master Jul 2, 2025
5 checks passed

hotzenklotz deleted the fix-footer branch July 2, 2025 09:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix contrast in credits footer #8718

fix contrast in credits footer #8718

Uh oh!

hotzenklotz commented Jun 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 25, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

hotzenklotz Jun 25, 2025

Uh oh!

hotzenklotz Jun 25, 2025

Uh oh!

MichaelBuessemeyer left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix contrast in credits footer #8718

fix contrast in credits footer #8718

Uh oh!

Conversation

hotzenklotz commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

URL of deployed dev instance (used for testing):

Steps to test:

Uh oh!

coderabbitai bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

hotzenklotz Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

hotzenklotz Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hotzenklotz commented Jun 25, 2025 •

edited

Loading

coderabbitai bot commented Jun 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)