Skip to content

chore: add the testing suite for scala3-sbt-bridge and tasty-core #23617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Jul 28, 2025

Add and enable the tests for scala3-sbt-bridge-nonbootstrapped and scala3-sbt-bridge-bootstrapped.
Add and enable the tests for scala3-tasty-core-nonbootstrapped and scala3-tasty-core-bootstrapped.

@hamzaremmal hamzaremmal self-assigned this Jul 28, 2025
Comment on lines +661 to +663

def next$access$1 = next

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotc doesn't generate this method yet and running the bootstrapped test we add in this PR and the Open Community Build both complains about it missing. I'm adding it here manually so we can make progress but we will have to add the mechanism to generate it. I'm curious about why MiMa never flagged this issue...

@hamzaremmal hamzaremmal force-pushed the add-sbt-bridge-tests branch from 087927e to 287f746 Compare July 28, 2025 17:21
@hamzaremmal hamzaremmal changed the title chore: add the testing suite for scala3-sbt-bridge chore: add the testing suite for scala3-sbt-bridge and tasty-core Jul 28, 2025
@hamzaremmal hamzaremmal marked this pull request as ready for review July 29, 2025 09:37
@hamzaremmal hamzaremmal requested a review from a team as a code owner July 29, 2025 09:37
@hamzaremmal hamzaremmal assigned Gedochao and unassigned hamzaremmal Jul 29, 2025
@hamzaremmal hamzaremmal requested a review from Gedochao July 29, 2025 09:37
@hamzaremmal hamzaremmal enabled auto-merge July 29, 2025 09:38
@hamzaremmal hamzaremmal merged commit 048ce6b into scala:main Jul 29, 2025
81 of 83 checks passed
@hamzaremmal hamzaremmal deleted the add-sbt-bridge-tests branch July 29, 2025 09:39
@WojciechMazur WojciechMazur added this to the 3.7.3 milestone Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants