ctest: add tests for size and alignment of structs, unions, and aliases, and signededness of aliases. #4556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what the CI error is, doesn't seem to be related to the PR. |
tgross35
requested changes
Jul 18, 2025
ctest-next/templates/test.c
Outdated
| uint32_t ctest_signededness_of__{{ alias.id }}(void) { | ||
| return ((({{ alias.c_ty }}) -1) < 0); | ||
| } | ||
| {%- endfor +%} |
There was a problem hiding this comment.
This is missing a trailing newline.
Does your editor have an option to insert this by default? E.g. vscode has files.insertFinalNewline
ctest-next/templates/test.c
Outdated
| // Return `1` if the type is signed, otherwise return `0`. | ||
| // Casting -1 to the aliased type if signed evaluates to `-1 < 0`, if unsigned to `MAX_VALUE < 0` | ||
| uint32_t ctest_signededness_of__{{ alias.id }}(void) { | ||
| return ((({{ alias.c_ty }}) -1) < 0); |
There was a problem hiding this comment.
I think this is a bit easier to read
Suggested change
| return ((({{ alias.c_ty }}) -1) < 0); | |
| { alias.c_ty } all_ones = -1; | |
| return all_ones < 0; |
ctest-next/src/translator.rs
Outdated
Comment on lines
332
to
334
| "char" | "short" | "int" | "long" | "long long" | "int8_t" | "int16_t" | ||
| | "int32_t" | "int64_t" | "uint8_t" | "uint16_t" | "uint32_t" | "uint64_t" | ||
| | "size_t" | "ssize_t" => true, |
There was a problem hiding this comment.
Maybe just add an arm s.starts_with("int") || s.starts_with("uint")
ctest-next/src/template.rs
Outdated
| helper: &TranslateHelper, | ||
| ) -> Result<(), TranslationError> { | ||
| for alias in helper.ffi_items.aliases() { | ||
| // && skip_signededness |
There was a problem hiding this comment.
Suggested change
| // && skip_signededness |
ctest-next/src/template.rs
Outdated
Comment on lines
167
to
168
| if helper.translator.is_signed(helper.ffi_items, &alias.ty) | ||
| && !should_skip_signededness_test |
There was a problem hiding this comment.
Early continue to unnest a level
Suggested change
| if helper.translator.is_signed(helper.ffi_items, &alias.ty) | |
| && !should_skip_signededness_test | |
| if !helper.translator.is_signed(helper.ffi_items, &alias.ty) || should_skip_signededness_test { | |
| continue; | |
| } |
mbyx
force-pushed
the
ctest-size-align-test
branch
from
2e05afe to
5ced981
Compare
…es, and signededness of aliases.
mbyx
force-pushed
the
ctest-size-align-test
branch
from
5ced981 to
48031a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests for verifying size and alignment of struct, union, and typedef types, as well as signededness of alias types (if they are signed).
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI