Skip to content

backport #839 (DefiniteDescriptorKey fixes) to 10.x #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

apoelstra
Copy link
Member

No description provided.

apoelstra added 2 commits July 5, 2025 21:21
Our current API allows constructing a DefiniteDescriptorKey with hardened steps,
which means that you can't actually derive a public key. However, the point of
this type is to provide a DescriptorPublicKey which implements the ToPublicKey
trait.

This is a backport, so it introduces the `has_hardened_steps` helper function
but does *not* make it pub, in the interest of avoiding gratuitious API changes.
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d61103f

Copy link
Member Author

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On d61103f successfully ran local tests

@apoelstra
Copy link
Member Author

Tagged and published.

@apoelstra apoelstra merged commit 1385aa7 into rust-bitcoin:release-10.x Jul 5, 2025
17 checks passed
@apoelstra apoelstra deleted the 2025-07_more_key-10.x branch July 5, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants