avm2: Return correct error for unclosed tags #21107
Open
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-avm2
The problem is that quick-xml returns the same error (UnclosedTag) in 2 distinct cases: 1. Unterminated attribute (Error 1095): <a b='/> 2. Malformed element (Error 1090): <a/><b></b This commit adds logic to differentiate between these cases by: - Checking if any XML events were successfully parsed before the error - If no events were parsed, examining the XML content for attribute patterns - If the content contains '=' and a quote character, it's Error 1095 - Otherwise, it's Error 1090
SuchAFuriousDeath
force-pushed
the
xml-1097-error
branch
from
16972f5 to
c001a62
Compare
|
I think I managed to fix it, but it's ugly :( |
kjarosh
added
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops, this looks more complicated than initially thought