AVM1: Avm1Function's base_clip should be a string path #20861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CUB3D
commented
Jun 29, 2025
| let func = Avm1Function::from_swf_function( | ||
| self.gc(), | ||
| swf_version, | ||
| func_data, | ||
| action, | ||
| self.scope(), | ||
| constant_pool, | ||
| self.base_clip(), | ||
| // `base_clip` should always be a living `MovieClip` so this can't fail | ||
| MovieClipReference::try_from_stage_object(self, bc).unwrap(), |
There was a problem hiding this comment.
I'm open for an alternative to the unwrap, but I've manged to convince myself it's safe
CUB3D
commented
Jun 29, 2025
n0samu
added
A-avm1
Lord-McSweeney
approved these changes
Jul 1, 2025
moulins
reviewed
Jul 17, 2025
CUB3D
force-pushed
the
avm1_function_string_path
branch
from
fa7c616 to
a16a6f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base_clip of an
Avm1Functionis also accessed with string path semantics.This fixes both #6124 and #14562