cluster/node events (#1855) #3083
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding events for cluster client, some people were interested in it.
I have read the issue but didn't see any concrete approved suggestions so i come up with some.
for cluster:
for nodes:
Node events provide host/port to identify a particular node.
I would like to hear suggestions or opinion if this feature needed.
issue #1855
Checklist
Does
npm test
pass with this change (including linting)?I tried to run tests via npm run build and npm test but it fails with timeout "before hook" after 30000ms after 1 hour of going a couple of time. But git checks are fine i guess.
Is the new or changed code fully tested?
I haven't seen any tests for emitting events, i have tested it only locally.
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
Can't find where i can update desctiption about cluster events.
I saw small section of client events on redis website.
Can't update that.