metastore: skip logging checkpoint on position::beginning #5922
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This log is written on every partition, even when there's no data loss.
The
position.cmp(&delta_position.from)
comparison doesn't account forPosition::Beginning
being not equal toPosition::offset(0u64)
. However logically speaking moving fromBeginning
to0u64
doesn't indicate any data loss -Position::Beginning
means that no data was processed, andPosition::offset(0)
means offset
0
was processed.How was this PR tested?