Add plan paste for easily accessing the sharding plan #3389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
aliafzal
force-pushed
the
export-D82945862
branch
from
8fa4d4b to
2d77de7
Compare
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Sep 23, 2025
Summary: internal This diff introduces additional logging of the complete sharding plan in a human-readable format, making it easily accessible for any review and analysis through the planner db dataset. Differential Revision: D82945862
aliafzal
force-pushed
the
export-D82945862
branch
from
2d77de7 to
b1a73da
Compare
Summary: Integrate PlanLoader functionality within the EmbeddingShardingPlanner to enable loading and reusing pre-computed sharding plans. This integration extends the OSS planner with plan loading capabilities. This diff includes: * PlanLoader Integration in EmbeddingShardingPlanner: - Added optional `plan_loader` parameter to EmbeddingShardingPlanner constructor - Integrated plan validation using context hash comparison to ensure loaded plans are compatible with current planner configuration - Fallback to normal planning when plan loader returns null * Plan Loading Workflow:Check if loaded plan context hash matches current planner context * If mismatch detected → raise PlannerError * If validation passes → load sharding options from storage * Map loaded sharding options to current search space using storage_hash * Skip planning phase and use pre-computed plan if available * Search Space Reconstruction: * Mapping of loaded sharding options to enumerated search space * Preserving all original ShardingOption metadata while replacing shard assignments Differential Revision: D81279558
Summary: internal This diff introduces additional logging of the complete sharding plan in a human-readable format, making it easily accessible for any review and analysis through the planner db dataset. Differential Revision: D82945862
aliafzal
force-pushed
the
export-D82945862
branch
from
b1a73da to
4ed9d8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff introduces additional logging of the complete sharding plan in a human-readable format, making it easily accessible for any review and analysis through the planner db dataset.
Differential Revision: D82945862