Skip to content

Conversation

larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Sep 27, 2025

As titled

Copy link

pytorch-bot bot commented Sep 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14643

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Unrelated Failures

As of commit 0e60d1b with merge base dfa17bc (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 27, 2025
@larryliu0820 larryliu0820 added the release notes: none Do not include this in the release notes label Sep 27, 2025
Copy link
Contributor

@kirklandsign kirklandsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I am still not sure about the use case. const vector& is a superset of vector&& ?

@larryliu0820
Copy link
Contributor Author

Sorry I am still not sure about the use case. const vector& is a superset of vector&& ?

If only const vector& then it doesn't take std::move(inputs), basically rvalues. With this new API you can do stuff like:

runner.generate({make_text_input("my prompt"), make_image_input(image_data)});

@larryliu0820 larryliu0820 merged commit db8d04f into main Sep 30, 2025
127 of 141 checks passed
@larryliu0820 larryliu0820 deleted the support_move branch September 30, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants