-
Notifications
You must be signed in to change notification settings - Fork 645
Use temp allocator for kernel registry #13012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13012
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 1 Unrelated FailureAs of commit c831756 with merge base 90ff059 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D79285675 |
This PR needs a
|
Summary: When indexing to the registry to get the op, memory is allocated from the method allocator to instantiate some TensorMeta and included objects. This memory is only used for that purpose and is not needed for the entire lifetime of the Method. Thus, we can instead use temp allocator which can later be reset and free up memory as needed. Differential Revision: D79285675
Summary: When indexing to the registry to get the op, memory is allocated from the method allocator to instantiate some TensorMeta and included objects. This memory is only used for that purpose and is not needed for the entire lifetime of the Method. Thus, we can instead use temp allocator which can later be reset and free up memory as needed. Differential Revision: D79285675
024df78
to
7128e81
Compare
This pull request was exported from Phabricator. Differential Revision: D79285675 |
7128e81
to
07a7687
Compare
Summary: Pull Request resolved: pytorch#13012 When indexing to the registry to get the op, memory is allocated from the method allocator to instantiate some TensorMeta and included objects. This memory is only used for that purpose and is not needed for the entire lifetime of the Method. Thus, we can instead use temp allocator which can later be reset and free up memory as needed. Differential Revision: D79285675
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this.
07a7687
to
c5ce955
Compare
Summary: When indexing to the registry to get the op, memory is allocated from the method allocator to instantiate some TensorMeta and included objects. This memory is only used for that purpose and is not needed for the entire lifetime of the Method. Thus, we can instead use temp allocator which can later be reset and free up memory as needed. Reviewed By: larryliu0820 Differential Revision: D79285675
This pull request was exported from Phabricator. Differential Revision: D79285675 |
Summary: Pull Request resolved: pytorch#13012 When indexing to the registry to get the op, memory is allocated from the method allocator to instantiate some TensorMeta and included objects. This memory is only used for that purpose and is not needed for the entire lifetime of the Method. Thus, we can instead use temp allocator which can later be reset and free up memory as needed. Reviewed By: larryliu0820 Differential Revision: D79285675
23ddf27
to
8f73ee3
Compare
Summary: When indexing to the registry to get the op, memory is allocated from the method allocator to instantiate some TensorMeta and included objects. This memory is only used for that purpose and is not needed for the entire lifetime of the Method. Thus, we can instead use temp allocator which can later be reset and free up memory as needed. Reviewed By: larryliu0820 Differential Revision: D79285675
This pull request was exported from Phabricator. Differential Revision: D79285675 |
Summary: Pull Request resolved: pytorch#13012 When indexing to the registry to get the op, memory is allocated from the method allocator to instantiate some TensorMeta and included objects. This memory is only used for that purpose and is not needed for the entire lifetime of the Method. Thus, we can instead use temp allocator which can later be reset and free up memory as needed. Reviewed By: larryliu0820 Differential Revision: D79285675
8f73ee3
to
1f41298
Compare
Summary: When indexing to the registry to get the op, memory is allocated from the method allocator to instantiate some TensorMeta and included objects. This memory is only used for that purpose and is not needed for the entire lifetime of the Method. Thus, we can instead use temp allocator which can later be reset and free up memory as needed. Reviewed By: larryliu0820 Differential Revision: D79285675
1f41298
to
433e6af
Compare
This pull request was exported from Phabricator. Differential Revision: D79285675 |
Summary: Pull Request resolved: pytorch#13012 When indexing to the registry to get the op, memory is allocated from the method allocator to instantiate some TensorMeta and included objects. This memory is only used for that purpose and is not needed for the entire lifetime of the Method. Thus, we can instead use temp allocator which can later be reset and free up memory as needed. Reviewed By: larryliu0820 Differential Revision: D79285675
433e6af
to
4e159e8
Compare
Summary: When indexing to the registry to get the op, memory is allocated from the method allocator to instantiate some TensorMeta and included objects. This memory is only used for that purpose and is not needed for the entire lifetime of the Method. Thus, we can instead use temp allocator which can later be reset and free up memory as needed. Reviewed By: larryliu0820 Differential Revision: D79285675
4e159e8
to
c8e360d
Compare
Summary: Pull Request resolved: pytorch#13012 When indexing to the registry to get the op, memory is allocated from the method allocator to instantiate some TensorMeta and included objects. This memory is only used for that purpose and is not needed for the entire lifetime of the Method. Thus, we can instead use temp allocator which can later be reset and free up memory as needed. Reviewed By: larryliu0820 Differential Revision: D79285675
This pull request was exported from Phabricator. Differential Revision: D79285675 |
c8e360d
to
c831756
Compare
Failing tests pre-existing. moshi from undefined libtorchaudio symbol, openvino from backend import. Landing. |
Summary: When indexing to the registry to get the op, memory is allocated from the method allocator to instantiate some TensorMeta and included objects. This memory is only used for that purpose and is not needed for the entire lifetime of the Method. Thus, we can instead use temp allocator which can later be reset and free up memory as needed.
Differential Revision: D79285675
cc @larryliu0820 @JacobSzwejbka @lucylq