equip etrecord class with save method #12978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D79205242](https://our.internmc.facebook.com/intern/diff/D79205242/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12978
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 7c0660a with merge base da0c80a ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Gasoonjia
added a commit
that referenced
this pull request
Jul 29, 2025
Differential Revision: [D79205242](https://our.internmc.facebook.com/intern/diff/D79205242/) ghstack-source-id: 299371637 Pull Request resolved: #12978
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79205242 |
GregoryComer
approved these changes
Jul 29, 2025
Differential Revision: [D79205242](https://our.internmc.facebook.com/intern/diff/D79205242/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Jul 29, 2025
Pull Request resolved: #12978 design doc: #12925 This diff creates a save function for etrecord class for export flow usage. Also make the codebase more structural to make lintrunner happy. Differential Revision: [D79205242](https://our.internmc.facebook.com/intern/diff/D79205242/) ghstack-source-id: 299401750
|
This pull request was exported from Phabricator. Differential Revision: D79205242 |
Differential Revision: [D79205242](https://our.internmc.facebook.com/intern/diff/D79205242/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79205242 |
Gasoonjia
added
release notes: none
facebook-github-bot
merged commit 02d7f19
into
gh/gasoonjia/29/base
99 of 105 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Gasoonjia
added a commit
that referenced
this pull request
Jul 31, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #12978 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/29/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/29/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/29/orig @diff-train-skip-merge Co-authored-by: gasoonjia <gasoonjia@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D79205242
umbrella issue: #12961