[EXIR] Update RemoveCloneOpsTransform to be dim order aware #12976
+68
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12976
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ad74bdf with merge base d1c87e4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
This was referenced Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 3 of 3 implementing a dim order aware clone op.
This PR updates the clone removal pass to retain layout changing
_clone_dim_orderops and remove no-op clones, ensuring memory layout is preserved through export.Related PRs:
_clone_dim_orderportable kernel_clone_dim_orderop and mapaten.cloneFixes #12645
Test plan
Added tests to verify:
All tests pass via:
python -m unittest exir.tests.test_memory_format_ops_pass